Skip to content

Fix linear scan in RequiredOrder #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 4 commits into from
Jul 24, 2026
Merged

Fix linear scan in RequiredOrder #43

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a27a0c4
Fix linear scan in RequiredOrder
SimonCropp Mar 27, 2026
311be0c
Merge branch 'main' into Fix-linear-scan-in-RequiredOrder
SimonCropp Mar 27, 2026
010f96a
Merge branch 'main' into Fix-linear-scan-in-RequiredOrder
SimonCropp Jul 24, 2026
2551c91
Merge branch 'main' into Fix-linear-scan-in-RequiredOrder
SimonCropp Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/EfOrderBy/RequiredOrder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
static class RequiredOrder
{
static ConcurrentBag<Type> validated = [];
static ConcurrentDictionary<Type, bool> validated = [];

public static void Validate(DbContext context)
{
var contextType = context.GetType();

// Only check and validate once per DbContext type
if (validated.Contains(contextType))
if (validated.ContainsKey(contextType))
{
return;
}
Expand All @@ -24,7 +24,7 @@ public static void Validate(DbContext context)

// Marked only after validation succeeds, so a failed validation keeps throwing
// instead of silently passing on every subsequent query
validated.Add(contextType);
validated.TryAdd(contextType, true);
}

static void ValidateAllEntitiesHaveOrdering(IModel model)
Expand Down
Loading