Skip to content

fix: use base64 BWIFI for WiFi credential provisioning #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JeromeRGero wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: use base64 BWIFI for WiFi credential provisioning #1745

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a44fd6e
fix: use base64 BWIFI for WiFi credential provisioning
JeromeRGero Feb 11, 2026
c3cdac9
Update server/android/src/main/java/dev/slimevr/android/serial/Androi…
JeromeRGero Feb 11, 2026
f07e767
Update server/desktop/src/main/java/dev/slimevr/desktop/serial/Deskto…
JeromeRGero Feb 11, 2026
8481276
Update server/desktop/src/main/java/dev/slimevr/desktop/serial/Deskto…
JeromeRGero Feb 11, 2026
5c8b7a1
Update server/android/src/main/java/dev/slimevr/android/serial/Androi…
JeromeRGero Feb 11, 2026
63b24ef
Fix String repeat inconsistency
ButterscotchV Feb 11, 2026
ab1256f
Fix issues with Kotlin Base64
ButterscotchV Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions server/android/src/main/java/dev/slimevr/android/serial/AndroidSerialHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,8 +281,11 @@ class AndroidSerialHandler(val activity: AppCompatActivity) :

@Synchronized
override fun setWifi(ssid: String, passwd: String) {
writeSerial("SET WIFI \"${ssid}\" \"${passwd}\"")
addLog("-> SET WIFI \"$ssid\" \"${passwd.replace(".".toRegex(), "*")}\"\n")
val encoder = java.util.Base64.getEncoder()
val b64ssid = encoder.encodeToString(ssid.toByteArray(StandardCharsets.UTF_8))
val b64passwd = encoder.encodeToString(passwd.toByteArray(StandardCharsets.UTF_8))
Comment thread
JeromeRGero marked this conversation as resolved.
Outdated
writeSerial("SET BWIFI $b64ssid $b64passwd")
addLog("-> SET BWIFI $b64ssid ${b64passwd.replace(".".toRegex(), "*")}\n")
Comment thread
JeromeRGero marked this conversation as resolved.
Outdated
}

override fun getCurrentPort(): SlimeSerialPort? = this.currentPort
Expand Down
7 changes: 5 additions & 2 deletions server/desktop/src/main/java/dev/slimevr/desktop/serial/DesktopSerialHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,12 @@ class DesktopSerialHandler :
val os = currentPort?.outputStream ?: return
val writer = OutputStreamWriter(os)
try {
writer.append("SET WIFI \"").append(ssid).append("\" \"").append(passwd).append("\"\n")
val encoder = java.util.Base64.getEncoder()
val b64ssid = encoder.encodeToString(ssid.toByteArray(StandardCharsets.UTF_8))
val b64passwd = encoder.encodeToString(passwd.toByteArray(StandardCharsets.UTF_8))
Comment thread
JeromeRGero marked this conversation as resolved.
Outdated
writer.append("SET BWIFI ").append(b64ssid).append(" ").append(b64passwd).append("\n")
writer.flush()
addLog("-> SET WIFI \"$ssid\" \"${passwd.replace(".".toRegex(), "*")}\"\n")
addLog("-> SET BWIFI $b64ssid ${b64passwd.replace(".".toRegex(), "*")}\n")
Comment thread
JeromeRGero marked this conversation as resolved.
Outdated
} catch (e: IOException) {
addLog("$e\n")
LogManager.warning("[SerialHandler] Serial port write error", e)
Expand Down