Skip to content

pgduck: expose BuildIcebergReadConversion on release-3.5 #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-okalaci merged 1 commit into from
Oct 12, 2026
Merged

pgduck: expose BuildIcebergReadConversion on release-3.5 #734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pg_lake_engine/include/pg_lake/pgduck/read_data.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,17 @@ extern PGDLLEXPORT char *TupleDescToProjectionList(TupleDesc tupleDesc,
bool addCast,
DataFileSchema * storageSchema);

/*
* Returns a DuckDB expression converting every INTERVAL and TIMETZ leaf in
* `expression` from its Iceberg storage representation to the surface type
* PostgreSQL expects, or NULL when none is needed. Recurses through arrays,
* composites, maps and domains. Applied automatically by
* TupleDescToProjectionList; declared here for callers that build their own
* query over Iceberg-format data.
*/
extern PGDLLEXPORT char *BuildIcebergReadConversion(const char *expression,
Oid typeOid, int32 typmod);

extern PGDLLEXPORT char *TupleDescToDuckDBColumnsMap(TupleDesc tupleDesc,
CopyDataFormat sourceFormat,
bool preferVarchar,
Expand Down
7 changes: 4 additions & 3 deletions pg_lake_engine/src/pgduck/read_data.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,6 @@ static char *BuildColumnProjection(char *expression,
static bool TypeNeedsIcebergReadConversion(Oid typeOid);
static void AppendIcebergReadConversion(StringInfo buf, const char *expression,
Oid typeOid, int32 typmod, int depth);
static char *BuildIcebergReadConversion(const char *expression, Oid typeOid,
int32 typmod);
static char *BuildStorageToSurfaceProjection(const char *columnName,
Oid columnTypeId, int32 columnTypeMod,
DuckDBTypeInfo duckdbType,
Expand Down Expand Up @@ -1300,8 +1298,11 @@ AppendIcebergReadConversion(StringInfo buf, const char *expression,
* BuildIcebergReadConversion returns a DuckDB expression that converts all
* native-type leaves in expression from their Iceberg representation to their
* PostgreSQL/DuckDB surface type, or NULL when no conversion is required.
*
* Declared in read_data.h so a caller building its own query over
* Iceberg-format data can apply the same conversion the read path applies.
*/
static char *
char *
BuildIcebergReadConversion(const char *expression, Oid typeOid, int32 typmod)
{
StringInfoData conversion;
Expand Down
Loading