Repository navigation
Update the guide for agentic-ai-for-asset-management to follow the code changes - #3606
Open
sfc-gh-mstellwall wants to merge 3 commits into
Open
sfc-gh-mstellwall wants to merge 3 commits into
sfc-gh-mstellwall wants to merge 3 commits into
Conversation
…de changes (in seperate repositroy) Documentation update to reflect the code changes, exists in another repository.
sfc-gh-amadan
requested changes
Oct 13, 2026
sfc-gh-amadan
left a comment
Contributor
There was a problem hiding this comment.
Blocking
- Merge order: the guide describes the Code Bundle setup from companion PR #5, but
mainstill has the old notebook-service setup. Merge #5 first, or readers following this guide will get a differentsetup.sql. - Clean up: #5 deletes
scripts/teardown.sql, and setup now also createsSAM_DEMO_BUNDLE_POOL,SAM_DEMO_ML_POOL,FSI_DEMO_BUILD_ROLE,SAM_DEMO_USER_ROLE, and an optional weekly refresh task. Restore a teardown script that covers these, and add a## Clean Upsection here that points to it.
Suggested
- Step 1 suggests naming the workspace "SAM Demo", but
setup.sqldefaultsws_nametoSAM_DEMO_WORKSPACE. SuggestSAM_DEMO_WORKSPACEin Step 1 so readers don't have to edit anything. - Link
scripts/setup.sql(Step 2) to its GitHub URL. Relative links don't resolve on snowflake.com.
Contributor
Author
|
Yes, I was hoping the PR #5 for the code repository would be merged, has changed that according to the comments on it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation update to reflect the code changes, exists in another repository.
This repository does not have any code, only the documentation for the guide.