Conversation
856e5ba to
fde1eda
Compare
|
I'm not against a formatter, but suggest (a) to add it to I appreciate the work and the CI job, but I find it much nicer to not bother a contributor to act on some formatting issues. I understand that e.g. dnsvizor/mollymawk have such a CI job which unfortunately at the moment only works for branches of the original repository (not on forks). Maybe this is already the case here? |
8ee1003 to
390d885
Compare
|
I’ve added the So I’ve created a new PR that adds I tried to keep the diff as minimal as possible, but not only were quite a few files imported, and the question of style is often very subjective. So I tried to achieve a configuration that was roughly consistent with what I could see in the code. |
|
cool. the ci check action is already a great thing so we don't end up with unformatted code. If you're happy with this, please feel free to merge. |
On top of #632, this PR introduce a new GitHub action which verifies that we respect a certain way to write our code. I also applied
clang-formaton the full codebase which generates a huge diff. I really tried to limit the diff and tweak a bitclang-format. We have two rules:formatwhich callsclang-format -iandformat-checkwhich is used by our CI. I also completed thecleanrules into thebindings/directory to deletenoexecstack.{c,h,s}.