Allow embeddables to be blank - #1434
Closed
aseroff wants to merge 4 commits into
Closed
Conversation
to support embeddables without any attributes
Contributor
|
Looks fine, but two remarks:
|
Contributor
Author
|
Ah, my bad. I'll resubmit once I've figured out the test issues. I have a form that has to sit inside text content. Previously I just set it up with an unnecessary attribute just to save it. Seemed worth fixing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to support embeddables without any attributes.
Context
#1433
Changes proposed in this pull request
loosen the strong params with
params.permit(embeddable: {}).fetch(:embeddable, {})Guidance to review
Million ways to skin this cat, this was just my take on it.