fix(arxiv): remove a rejected failed-conversion page before falling back - #14
Merged
Merged
Conversation
When the cached copy of a paper is ar5iv's failed-conversion page and both ar5iv and the PDF mirror miss, the call falls through to the upstream server, which serves any cached Markdown file as it is, so the rejected page could still come back. The bridge now deletes the rejected cache entry before any fallback, and returns an error instead of forwarding when the file cannot be removed. Adds download_paper and read_paper tests with both fetch paths failing; both fail before this change. Same fix as psi-oss#278 (found in review there).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the cached copy of a paper is ar5iv's failed-conversion page and both ar5iv and the PDF mirror miss, the call falls through to the upstream arXiv server, which serves any cached Markdown file as it is, so the rejected page could still come back. The bridge now deletes the rejected cache entry before any fallback, and returns an error instead of forwarding when the file cannot be removed.
Found in review of the same change offered upstream (psi-oss#278).
Testing: new download_paper and read_paper tests with both fetch paths failing (both fail before this change); full suite 13029 passed with the three known environment failures.