Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sean-sqds
marked this pull request as ready for review
June 9, 2026 22:01
0xRigel-squads
approved these changes
Jul 28, 2026
…execute-prepends-every-supplied
jeff-sqds
deleted the
feature/mul-753-v4-9-rust-vault_transaction_execute-prepends-every-supplied
branch
October 7, 2026 18:28
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a regression in how lookup table accounts are handled in vault transaction execution, ensuring correct alignment with on-chain validation. The main change is to build the lookup table account metas from the message's referenced tables in the correct order, rather than from the raw caller-supplied slice. This prevents execution failures when the supplied lookup tables are a superset or reordered. Additionally, comprehensive regression tests have been added to verify this behavior and error handling for missing referenced tables.
Fixes to lookup table account meta handling:
VaultTransactionMessageExttrait's implementation now constructslookup_table_account_metasfrommessage.address_table_lookupsin message order, ensuring only referenced tables are included and in the correct order. This matches the on-chain validator's expectations and prevents desyncs that could brick execution.Regression tests for correct ALT handling:
vault_transaction_execute_alt.rswith regression tests to verify that: