Skip to content

feat(sdk): ATL Check - #187

Merged
sean-sqds merged 2 commits into
mainfrom
feature/mul-753-v4-9-rust-vault_transaction_execute-prepends-every-supplied
Jul 29, 2026
Merged

sean-sqds merged 2 commits into
mainfrom
feature/mul-753-v4-9-rust-vault_transaction_execute-prepends-every-supplied

Conversation

@sean-sqds

Copy link
Copy Markdown
Contributor

This pull request addresses a regression in how lookup table accounts are handled in vault transaction execution, ensuring correct alignment with on-chain validation. The main change is to build the lookup table account metas from the message's referenced tables in the correct order, rather than from the raw caller-supplied slice. This prevents execution failures when the supplied lookup tables are a superset or reordered. Additionally, comprehensive regression tests have been added to verify this behavior and error handling for missing referenced tables.

Fixes to lookup table account meta handling:

  • The VaultTransactionMessageExt trait's implementation now constructs lookup_table_account_metas from message.address_table_lookups in message order, ensuring only referenced tables are included and in the correct order. This matches the on-chain validator's expectations and prevents desyncs that could brick execution.

Regression tests for correct ALT handling:

  • Added a new test file vault_transaction_execute_alt.rs with regression tests to verify that:
    • Only message-referenced lookup tables are emitted, in message order, regardless of the caller-supplied slice's order or superset.
    • The helper returns an error if a referenced lookup table is missing from the supplied accounts.

@vercel

vercel Bot commented Jun 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
v4-sdk-typedoc Ready Ready Preview, Comment Jul 29, 2026 12:36pm

Request Review

@sean-sqds
sean-sqds marked this pull request as ready for review June 9, 2026 22:01

@bguillaumat-squads bguillaumat-squads left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@sean-sqds
sean-sqds merged commit 6b86f8a into main Jul 29, 2026
4 of 5 checks passed
@jeff-sqds
jeff-sqds deleted the feature/mul-753-v4-9-rust-vault_transaction_execute-prepends-every-supplied branch October 7, 2026 18:28

This branch was successfully deployed

1 active deployment
Preview — 838f3bc9 Deployed Jul 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants