Repository navigation
Conversation
`multisigChangeThreshold` was exposed in `instructions` and `transactions` (Squads-Protocol#99) but not in `rpc`, unlike the other controlled multisig config instructions such as `multisigSetTimeLock`. Also make the unused `spendingLimit` parameter of `transactions.multisigChangeThreshold` optional, so callers no longer need to pass a placeholder key. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@aelmanaa is attempting to deploy a commit to the squads Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #203
rpc.multisigChangeThreshold, followingrpc.multisigSetTimeLock/rpc.multisigAddMember.transactions.multisigChangeThresholdusesrentPayeras the fee payer, so the rpc function takesrentPayeras aSignerand signs with it plussigners.spendingLimitparameter oftransactions.multisigChangeThresholdoptional. Existing callers that pass it keep compiling.Tests: a new
multisig_change_threshold for a controlled multisigblock intests/suites/multisig-sdk.tschecks that a wrong config authority is rejected and that the threshold of a controlled multisig changes to 2 on chain.I ran the full suite like
anchor test: the program built withcargo build-sbf --features testing, loaded at the test program id insolana-test-validatorwith theAnchor.tomlfixture, thenmocha tests/index.ts.main: 160 passing, 12 pending, 3 failing. This branch: 162 passing, 12 pending, the same 3 failing. Those 3 expect/Transaction signature verification failure/, while the local Solana 3.1 validator reportsTransaction did not pass signature verification, so they are unrelated to this change.yarn tsinsdk/multisigpasses, and the rootyarn tsreports the same errors onmainand here.This PR was prepared with Claude Code; the tests above were run locally.