Repository navigation
Allow OrderedCollections 2 (and Parameters 0.13) - #53
Open
matthew-liu-1 wants to merge 1 commit into
Open
matthew-liu-1 wants to merge 1 commit into
matthew-liu-1 wants to merge 1 commit into
Conversation
OrderedCollections 2.0.1 is available. Parameters 0.13.1 is the first Parameters release that allows it. This change widens both compat entries and bumps the patch version. StanBase uses only OrderedDict and @unpack. Both are unchanged in the new major versions.
matthew-liu-1
force-pushed
the
compat/orderedcollections-2
branch
from
September 30, 2026 03:19
d400e52 to
682fbf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Widens two compat bounds so StanBase can be used in environments that need
OrderedCollections 2, and bumps the patch version to 4.12.5.
Parametershas to move together withOrderedCollections: everyParameters0.12.x release caps
OrderedCollectionsto 1.x, so 0.13.1 is the only release inthe 0.12–0.13 range that admits OrderedCollections 2. That indirection is why
this looked like a StanSample-only problem at first.
Motivation
@bparbhu — for context on why we're asking for this: we're trying to run
MLJLinearModels at head, which needs OrderedCollections 2 in the resolved
environment. StanBase and StanSample are currently the StanJulia-side pins that
prevent our environment from getting there (together with StanOptimize, which has
the same
Parameters = "0.12"cap — companion PR filed there too).Why no code changes are needed
StanBase's entire surface against these two packages is:
typeof(input) <: OrderedCollections.OrderedDictsrc/common/update_json_files.jl:53@unpack cmdstan_home, exec_path = msrc/common/common_definitions.jl:91OrderedCollections 2.0's breaking changes are: removal of the deprecated
similar(::OrderedDict)/similar(::OrderedSet)/sort(::Dict)methods,removal of deprecated
OrderedSetindexing,convert(OrderedDict, ::AbstractDict)on an unordered dict now throwing instead of warning,
first/laston an emptycollection throwing
ArgumentError, and a changed internalOrderedDictstructlayout (new
live,firstlive,lastlivefields). StanBase touches none of them.Parameters 0.13's only breaking change is dropping the deprecated
@packalias(
@pack!stays). StanBase uses@unpackonly.Testing
Julia 1.10.12, Linux x86_64, CmdStan 2.36.0.
green under OrderedCollections 2.0.1: 260 passed, 0 failed.
so nothing here is OrderedCollections-2-specific.