Repository navigation
Allow Parameters 0.13 so OrderedCollections 2 can resolve - #39
Open
matthew-liu-1 wants to merge 1 commit into
Open
matthew-liu-1 wants to merge 1 commit into
matthew-liu-1 wants to merge 1 commit into
Conversation
Widens one compat bound and bumps the patch version to 4.4.5. StanOptimize does not depend on OrderedCollections directly, so this looks unrelated, but every Parameters 0.12.x release caps OrderedCollections to 1.x. With `Parameters = "0.12"` here, StanOptimize transitively pins OrderedCollections below 2 for every environment that includes it. Parameters 0.13.1 is the only release in the 0.12-0.13 range that admits OrderedCollections 2. No code changes are needed: StanOptimize imports Parameters but uses no macro from it anywhere in src/, and Parameters 0.13's only breaking change is dropping the deprecated `@pack` alias.
matthew-liu-1
force-pushed
the
compat/orderedcollections-2
branch
from
September 30, 2026 03:19
d908c37 to
1bafa6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Widens one compat bound so StanOptimize can be used in environments that need
OrderedCollections 2, and bumps the patch version to 4.4.5.
Why this matters for OrderedCollections 2
StanOptimize has no
OrderedCollectionsdependency at all, so this looksunrelated — but every
Parameters0.12.x release capsOrderedCollectionsto1.x. With
Parameters = "0.12"here, StanOptimize transitively pinsOrderedCollectionsbelow 2 for any environment that includes it.Parameters0.13.1 is the only release in the 0.12–0.13 range that admits OrderedCollections 2.
Companion PRs widen the same bound (plus
OrderedCollectionsitself) inStanJulia/StanSample.jl and StanJulia/StanBase.jl. All three are needed together;
any one of them left at
Parameters = "0.12"keeps the whole environment onOrderedCollections 1.x. We hit this trying to run MLJLinearModels at head, which
needs OrderedCollections 2 in the resolved environment.
Why no code changes are needed
StanOptimize imports
Parametersbut uses no macro from it anywhere insrc/— no
@with_kw,@unpack,@pack!,reconstructortype2dict. Parameters0.13's only breaking change is dropping the deprecated
@packalias (@pack!stays).
Testing
Julia 1.10.12, Linux x86_64, CmdStan 2.32.0 and 2.36.0.
stan_optimizeruns correctly end-to-end on a Bernoulli model (success(rc) == true).resolves at OrderedCollections 2.0.1, and StanSample's own suite is green there
(260 passed, 0 failed).