Repository navigation
Preserve hydrated Messages cartouches during loading - #729
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading earlier Messages pages replaced every bubble with fresh HTML, resetting already hydrated concept cartouches to placeholders until asynchronous hydration completed. Reconcile contributions by ID and rendered data so unchanged bubbles remain mounted; prepare changed bubbles off-screen. The refresh comparison also includes metadata, so subject/attachment edits are not silently skipped.
Validation: 28 targeted Jest tests passed; the new delayed-HTTP Playwright regression passes at 390px and 1280px with zero removals of retained cartouches during pagination and new-message refresh, and checks metadata edits and deletion. The same regression fails on baseline cee226b at the retained-node assertion. Existing unread-navigation browser checks pass at both sizes. Static lint and diff checks pass. Screenshots inspected; local evidence:
.run/message-cartouche-refresh/and.run/message-cartouche-unread/.Merge decision changes — bounded Tier 1 evidence supports delivery. Browser checks use the actual renderer/CSS with synthetic HTTP data; authenticated live acceptance was not performed. Host browser profiles documented for other tasks were not reused. No deployment requested.
Von task: #V#task_agent_4416c9704bf6e6df73c8b52014554bd7.
Source screenshot: #V#computer_file_copy_0378e359e9fb4ae29842ef888384ff03, SHA-256 cd62082794445a3f414433add805447ca84fb196b49a1976aaf1ac5dfc679c57 (staged bytes inspected).