Repository navigation
Fix scoped temporary model selection and reasoning controls - #743
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge decision: ready — the temporary model picker offers scoped executable catalogue entries and sends the selected reasoning effort for one turn, including queued turns.
User outcome
The picker previously offered provider-catalogue models which Von would reject as disabled, and provided no reasoning selector. It now intersects discovery with the trusted actor's resolved enabled pool using the execution gate's exact provider/model normalisation. Settings discovery remains available for enabling additional models; Ollama retains its existing local-execution exception.
Native assignment:
#V#task_agent_8a925d88fa83a8889fe05cd36b8dcb98(Michael Witbrock).Material changes
gpt-6-astrawhen declared supported, the provider parameter mapping and value domain. Explicit registry values, fixed values and omissions remain authoritative. No model is enabled by these metadata changes and no blanket GPT-6 support is inferred.Evidence
git diff --checkpass.Queued/Runninglabels absent). Other 33 queue tests pass; these pre-existing failures do not change the merge decision.Ship boundary
Minimum criteria are exact scoped catalogue filtering, reasoning selection reaching the request, and registry-only reasoning metadata reaching provider kwargs without weakening execution eligibility. The targeted tests and browser fixture cover those criteria.
The historical user/organisation rejection configuration and the live Astra registry entry remain unverified. Browser evidence is synthetic fixture acceptance, not authenticated/public-service or provider acceptance. The retained authenticated browser helpers are bound to other candidates and were not reused. No deployment, registry mutation, credential change or schema migration is requested or performed.