Prevent Manager progress comments from invalidating deployment - #757
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Manager can now assign work to itself, so its own comments enter the authorised task context. A progress comment then changes the instruction fingerprint and can reject an otherwise authorised deployment. Keep self-authored comments available as context and explicit retry evidence, while excluding them from the changed-instruction check. Supervisor comments on another worker and human instruction changes still invalidate the fingerprint.
Validation: 111 worker, operator, inbox and canonical replay tests pass. The regression checks cover self-authored comments, supervisor input, human cancellation and legacy unattributed comments. This issue was found during the real Manager capability acceptance; the existing blocked attempt and child task are retained for continuation.