Require substantive Manager review receipts and reconcile supervisor reporting - #758
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Manager observer treated any nonempty reply, including a queue acknowledgement, as completed review. Add source-bound substantive review receipts and retain one pending review plus the latest successor across reordered events and interrupted delivery/read-back. Legacy answered cursors remain historical delivery evidence.
Worker reports also omitted the task's canonical supervisor. Preserve Michael's existing delivery and send a separate idempotent, scope-checked supervisor report. The existing supervisor inbox accepts that report as context only; it cannot reopen the child or turn the report into an assignment. A bounded controller option recovers a selected completed attempt's missing report without rerunning coding or changing the original message's audience.
Validation: 130 targeted review, worker, inbox, supervisor and canonical replay tests passed; syntax and diff checks passed. PR755's source-bound analysis handoff is reused unchanged. Live recurring-review activation is separately verified with the operator's existing schedule/lock and a real changed snapshot; publication alone is not activation. No web deployment.