Skip to content

Typescript related peerDependencies trigger errors in npm list #21

Description

@johnhunter

typescript and @types/react are included as peerDependencies although they seem to be optional. I don't use Typescript and don't want to install them. But npm install raises warnings for these missing peer deps. Worse is that npm list errors on them and this breaks https://github.com/pivotal/LicenseFinder which we use in our CI pipeline.

Maybe these should be devDependencies?

    "peerDependencies": {
        "@types/react": "^16.8.20",
        "react": "^16.8.x",
        "typescript": "^3.5.2"
    },

https://github.com/Swizec/useDimensions/blob/master/package.json#L21-L25

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions