Repository navigation
feat: hide doctrine:fixtures:load from production containers - #2
Merged
Merged
Conversation
Loading fixtures purges every Doctrine-mapped table. A compiler pass drops the console.command tag when kernel.environment is prod or production, so an accidental production install cannot expose the purge.
Covers purge scope (WordPress tables survive), references, dependencies, --append, --group and the production guard against SQLite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ProductionGuardPassremoves theconsole.commandtag fromdoctrine.fixtures_load_commandwhenkernel.environmentisprodorproduction. Loading fixtures purges every Doctrine-mapped table; with SymPress'extra.kerneldiscovery the bundle is active in every environment it is installed in, so an accidental non-dev install must not expose the purge. The pass runs before the kernel collects console commands; upstream passes still see the service, which is then removed as unused.ConsoleApplicationFactory:DependentFixtureInterfaceordering resolve,wp_poststable and its row survive the purge (ORM purger only touches mapped tables),--groupand--appendoptions,doctrine:fixtures:load, while other Doctrine commands stay available.phpstan/phpstan-doctrine(same assympress/doctrine-bundle) so PHPStan understands generated entity IDs.Verification
composer qapasses locally on PHP 8.5 (5 tests, 37 assertions).