Skip to content

Adopt superseded histories and enforce shared session-owned locks - #10

Merged
brianvarskonst merged 1 commit into
mainfrom
fix/review-followup-20261003
Oct 3, 2026
Merged

brianvarskonst merged 1 commit into
mainfrom
fix/review-followup-20261003

Conversation

@brianvarskonst

Copy link
Copy Markdown
Member

Allow explicit retirement of superseded legacy identities while preserving the canonical migration version and history. The status command prints the exact legacy keys and adoption command. Expected operational failures have a dedicated exception; unexpected PHP errors stop bulk migration and retain their trace.

Use a shared database migration lock across plugins and table prefixes, check session ownership before and after execution, expose lock timeouts, and reject keys longer than the 191-byte database column.

Validation: full QA, 79 tests / 514 assertions; real MariaDB 11.8 and MySQL 8.4, 9 tests / 98 assertions each, including connection replacement and contention. No skips. Connection loss during the database client's internal SQL replay is explicitly reported as requiring reconciliation.

@brianvarskonst
brianvarskonst merged commit 6d007cf into main Oct 3, 2026
6 checks passed
@brianvarskonst
brianvarskonst deleted the fix/review-followup-20261003 branch October 6, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant