Repository navigation
fix(handler): fall back to the error log for a read-only log dir - #14
Merged
Merged
Conversation
Deployments often ship the release read-only for the PHP user, so the default rotating file under var/log could not be opened and every log call threw. The default and security audit handlers now write to PHP's error log in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultHandlerFactoryalways built aRotatingFileHandlerunder%kernel.logs_dir%(defaultvar/login the project). When a deployment ships the release read-only for the PHP user, the first log call throwsUnexpectedValueException(stream could not be opened), so a logged warning becomes a fatal error.The factory now checks whether the log file's directory, or its nearest existing parent, is writable. If not, the default and security audit handlers use
ErrorLogHandlerwith the same level, so records still reach PHP's error log (php-fpm or the web server collects it). A disabledlogs_dir(empty, false, null) still disables the sink.Tests
ErrorLogHandlerthat keeps the production level (warning, not debug).phpunit43/43,phpstanno errors,qa csclean.Release: patch,
v1.1.6.