Repository navigation
feat: replace WP Starter with SymPress Runtime - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime migration review
The project replaces WP Starter with
sympress/runtime. Its configuration isdev-ops/runtime.json; compatibility is disabled and dotenv local overrides remain explicitly disabled to preserve the existing two-file convention. The command provider uses the injected environment reader and database status from Runtime preflight. The base MU package declares kernel boot ownership.The dependency follows Runtime main in its private repository; the lockfile pins merged commit
60249ee25ead52f94e2b83e9be4ce472cd3b2fcf. All six implementation PRs and review corrections #7 are merged. Private repository access is required through SSH or Composer GitHub authentication. WP-CLI is the independently executed, SHA512-verified root phar; removing the Composer WP-CLI bundle avoids its conflict with Symfony Process 8.1 while retaining all commands.Public WordPress URLs remain at the site root:
WP_SITEURL=${WP_HOME}. The original DDEV Nginx rules map public endpoints to the physicalpublic/wpcore directory. No Nginx routing changes are required by this migration. The starter setup command and documentation use the same root URL.Verification in a fresh DDEV project with a separate database:
wecodemore/*dependency.bin/console doctor --jsonandwp console doctor --jsonreport 14 passing checks.wp console debug:containersucceeds./wp-login.phpform action and authenticated root/wp-admin/dashboard with no JavaScript errors.Reproduce with
ddev composer install,ddev composer qa,ddev exec php bin/console doctor --json, andddev exec php wp-cli.phar console debug:container. Runtime'stools/consumer-smoke.mjsperforms the browser checks using the private local environment credentials. WP-CLI 2.12 can print upstream PHP 8.5 deprecations; use the standalone doctor for clean machine-readable JSON.Repeated Composer installation, global
composer install --no-pluginsand the standalone runner preserve 575 generated file hashes/link targets on the reviewed revision. Runtime restores the standard WordPress package layout and Composer autoload metadata before loading project code. QA and root-URL browser smoke pass again with this lockfile. Runtime's mandatory integration and differential job passes all 1,059 tests / 7,365 assertions without skips, the evidence check for 407 rows and 251 differential cases. Its real WPackagist installation job also passes. The previous CI authentication blocker is resolved by the read-only deploy key described below. Successful consumer CI is required before merge; Runtime's documented offline recovery boundaries still apply.Existing uncommitted changes in the original checkout were preserved by implementing this migration in a separate Git worktree. Generated configuration, local credentials and browser sessions are not committed.
The project owner approved enabling deploy keys for SymPress. A repository-scoped, read-only Runtime key now supplies
COMPOSER_SSH_KEYto the consumer workflows;COMPOSER_SSH_KNOWN_HOSTSpins GitHub's published host keys. The workflows are pinned to the reviewed SSH-support commit. CI must pass with that access before merge. When updating an existing environment from a previous/wpURL, runvendor/bin/sympress-runtime flush-env-cacheso cached values cannot retain that URL.