Skip to content

feat(ci): codecov fallback #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hamza-syndica merged 14 commits into from
Jul 15, 2026
Merged

feat(ci): codecov fallback #1718

Changes from 12 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1b8c8f0
shred: accept parent_offset == slot at any slot
yewman Jul 1, 2026
68fed12
shred: widen data-payload-size bound check to u32
yewman Jul 1, 2026
6f26553
shred/receiver: reject LAST_SHRED_IN_SLOT at misaligned index
yewman Jul 13, 2026
a94688d
shred/receiver: introduce dead-slot signal
yewman Jul 13, 2026
939fd90
shred/receiver: enforce per-slot parent_slot
yewman Jul 13, 2026
9e87ce8
shred/receiver: pin chained_merkle_root within a FEC set and dead-slo…
yewman Jul 13, 2026
710dbf7
shred/receiver: enforce cross-FEC chained_merkle_root chain (SIMD-0340)
yewman Jul 13, 2026
0de55b8
shred/receiver: re-validate Reed-Solomon-recovered data shreds
yewman Jul 13, 2026
06d9c9a
external codecov test
hamza-syndica Jul 13, 2026
4094d9c
fix deprecated api use
hamza-syndica Jul 13, 2026
0729f01
Merge branch 'harnew/v2-shred-parse-conformance' into hamza/external-…
hamza-syndica Jul 14, 2026
8b6f6c1
Revert "Merge branch 'harnew/v2-shred-parse-conformance' into hamza/e…
hamza72x Jul 14, 2026
390d8b7
Update .github/workflows/check_linux.yml
hamza-syndica Jul 15, 2026
0a8e6f7
Update .github/workflows/check_linux.yml
hamza-syndica Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/check_linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,32 @@ jobs:
echo "--- v2 filename samples ---"
grep 'filename=' v2/zig-out/kcov/kcov-merged/cobertura.xml | head -3

- name: Generate local coverage report
if: github.event_name == 'pull_request'
run: |
pip install --quiet diff-cover
Comment thread
hamza-syndica marked this conversation as resolved.
Outdated
# Determine the base branch to diff against
BASE_REF="origin/${{ github.base_ref }}"
echo "Comparing coverage against $BASE_REF"

# Run diff-cover on both v1 and v2 cobertura reports
diff-cover \
kcov-merged/kcov-merged/cobertura.xml \
v2/zig-out/kcov/kcov-merged/cobertura.xml \
--compare-branch="$BASE_REF" \
--format markdown:diff-coverage.md \
--fail-under 0 || true
Comment thread
dnut marked this conversation as resolved.
Outdated
Comment thread
hamza-syndica marked this conversation as resolved.
Outdated

# Output to GitHub step summary
if [ -f diff-coverage.md ]; then
echo "## Patch Coverage Report" >> "$GITHUB_STEP_SUMMARY"
cat diff-coverage.md >> "$GITHUB_STEP_SUMMARY"
else
echo "⚠️ diff-cover produced no output" >> "$GITHUB_STEP_SUMMARY"
fi

- name: Upload coverage to Codecov
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
PR_HEAD_SHA: ${{ github.event.pull_request.head.sha }}
Expand Down
Loading