fix(accountsdb): don't hang when no peer serves an incremental snapshot - #1767
Open
0xzrf wants to merge 1 commit into
Open
fix(accountsdb): don't hang when no peer serves an incremental snapshot#17670xzrf wants to merge 1 commit into
0xzrf wants to merge 1 commit into
Conversation
…s an incremental snapshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1763
Problem
Bootstrapping against a cluster whose peers serve no incremental snapshots (e.g. a local
solana-test-validator) hangs forever after the full snapshot downloads. IndownloadSnapshotWithRetry, a peer with no incremental is skipped beforedl_attemptsis incremented, and the validator sets no timeout — the retry loop never exits, so the RPC server never starts.Changes
error.UnableToDownloadSnapshotso the existing fallback indownloadSnapshotsFromGossipboots from the full snapshot only.Notes
Verified against
solana-test-validator(Agave 4.1.2): previously the loop spun forever; now it gives up after ~25s and startup continues. An epoch-0 cluster then hits an unrelatederror.InvalidInsertinEpochTracker.initFromManifest— will file separately.