Upgrade all dependencies by zettseb · Pull Request #574 · TNG/virtual-office

zettseb · 2026-06-23T15:58:36Z

Runtime & tooling

Node 24 (from 14/16/20), pnpm 11 (from npm) with strict mode + workspace config
ESM migration ("type": "module") for server and client
Vite 8 (from 2), TypeScript 5.9 (from 3.9), Jest 30 + ts-jest 29.4
@swc-node/register replaces tsx for dev server (preserves design:paramtypes decorator metadata typedi needs)
Cypress 15 (from 7), nodemon 3, prettier 3, husky 9

Client

React 18 (from 17, with createRoot migration; React 19 tried but rolled back — MUI 4 incompatible)
react-router-dom 6 (from 5), chai 5 (from 4), luxon 3 (from 1)
MUI 4 deep-path imports fixed — Vite 8's esbuild optimizer broke import X from "@material-ui/core/Box/Box" and @material-ui/icons/* default imports; switched to named imports from barrels

Server

express 4.22, body-parser 1.20.5, passport 0.7, socket.io 4.8, pino 9
lodash ESM interop fix (named → default imports; Node 24 cjs-module-lexer can't detect named exports)
api.json Docker runtime fix (Node 24 enforces with { type: "json" } import attribute; switched to readFileSync + findRootDir, copied source file into runtime image)
typedi 0.10 DI restored (was silently broken since tsx migration — design:paramtypes metadata missing)

Tests

Add tests more tests were applicable
Fix existing flaky tests

Not addressed

MUI 4 EOL — blocks React 19 upgrade (findDOMNode removed). Migration to MUI 5/6 can be done as follow-up

RESULT

Security: 0 audit vulnerabilities (qs/ws/js-yaml overrides applied)

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

- Add type:module to root, server, client package.json - Server tsconfig: module Node16, moduleResolution Node16 - Client tsconfig: keep moduleResolution node (Vite handles ESM) - Rename jest.config.js -> jest.config.cjs (CJS syntax with type:module) - Add .js extensions to all server relative imports (required by Node16) - Replace __dirname in findRootDir.ts with process.cwd() traversal - Replace require(configFile) with JSON.parse(fs.readFileSync) - Replace require('socket.io') with ESM import - Update nodemon/ts-node exec for ESM loader - Update server scripts for ESM compatibility - Add dotenv/axios module declarations for Node16 resolution - Remove @types/axios (axios bundles own types) Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

…est 7 Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

… → 14 Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

…udit vulns Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

fix: eliminate test handle leaks (pino worker thread, GroupJoinService interval) Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

…lution Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

…tion Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

- Delete package-lock.json, add pnpm-lock.yaml - Add @types/body-parser, @types/sinonjs__fake-timers, @types/luxon, @slack/types as explicit deps (pnpm strict requires declared deps) - Fix express-serve-static-core import → express (pnpm strict doesn't hoist transitive types) - Remove unused Container imports in integration specs (noUnusedLocals) - Fix Jest transformIgnorePatterns regex for pnpm .pnpm symlink paths Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

tsx (esbuild) does not emit design:paramtypes decorator metadata, which typedi 0.10 needs for constructor injection. Switch dev loader to @swc-node/register/esm-register (respects emitDecoratorMetadata, resolves .js -> .ts in ESM). Also fix ESM/CJS interop issues that surfaced in the compiled build: - lodash named imports fail in Node ESM (cjs-module-lexer cannot detect them); switch to default import + lodash.fn calls - api.json import fails with ERR_IMPORT_ATTRIBUTE_MISSING on Node 24; read via fs.readFileSync + findRootDir instead Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

Vite 8's esbuild dep optimizer mis-handles MUI 4's deep-path CJS modules: it emits 'export default require_X()' which returns the module namespace object instead of the component, causing React error #130 (element type invalid: got object). Switch all deep-path default imports to named imports from the barrels @material-ui/core and @material-ui/icons. React 19 removed findDOMNode, which MUI 4 (Popper, Tooltip, Menu) relies on, so keep React 18 until MUI is upgraded. Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

Luxon's TIME_SIMPLE formatter emits U+202F (narrow no-break space) between time and AM/PM marker in some locales. Replace it with a regular space so tests and UI display consistent output. Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

zettseb added 30 commits June 23, 2026 18:04

docs: add dependency upgrade implementation plan

5efaa02

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

test: add unit tests for enrichParticipant

7c3a063

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

test: add unit tests for comparableUsername

29100f5

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

test: add unit tests for mapMeetingEventToMeetings

a24c0c7

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

test: add unit tests for selectGroupsWithRooms

2be82d1

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

refactor: expose Express app on TestServer

8272a6c

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

test: add unit tests for ClientConfigService

206dabf

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

test: add integration tests for ApiRoute

b434f52

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

test: add unit tests for ensureLoggedIn middleware

409aec0

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

test: add component smoke tests for Login

adc6bd6

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

test: add component smoke tests for RoomCard

7c2f490

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

feat: upgrade Jest 27 → 29, ts-jest 27 → 29

da541fc

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

feat: upgrade TypeScript 4.9 → 5.8

b6967f7

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

feat: upgrade nodemon 2 → 3, prettier 2 → 3, husky 7 → 9, Cypress 7 → 13

7ed4c72

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

feat: upgrade luxon 3, @slack/web-api 7, swagger-ui-express 5, supert…

532bcaa

…est 7 Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

chore: remove @types/socket.io-client, upgrade @sinonjs/fake-timers 8…

ef84db6

… → 14 Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

feat: upgrade React 17 → 18, migrate to createRoot

91c3f8e

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

feat: upgrade chai 4 → 5

0fd978c

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

feat: upgrade react-router-dom 5 → 6

beb14f5

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

feat: update engines to Node 24/npm 10, replace ts-node with tsx

031f715

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

feat: upgrade Vite 6 → 8

2acb8e1

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

feat: upgrade Jest 29→30, ts-jest 29.4.11, engines >=24, client luxon 3

edcddd2

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

fix: patch express/body-parser qs vuln, add ws/js-yaml overrides, 0 a…

80865f9

…udit vulns Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

fix: resolve GroupJoin flaky test with tickAsync and shouldAdvanceTime

a80c61d

fix: eliminate test handle leaks (pino worker thread, GroupJoinService interval) Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

chore: add pnpm-workspace.yaml and .npmrc

a695af7

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

chore: switch root package.json from npm to pnpm

edba5c3

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

chore: switch server/client engines from npm to pnpm

173b3e1

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

fix: switch pino calls to object-first form for pnpm strict type reso…

5b0503d

…lution Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

fix: add swagger-ui-express module declaration for pnpm strict resolu…

adca110

…tion Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

zettseb added 8 commits June 23, 2026 18:04

fix: update Jest transformIgnorePatterns for pnpm .pnpm symlink paths

a796dc6

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

chore: update Dockerfile, CI workflow, and Renovate for pnpm

fc3b7ff

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

docs: update npm references to pnpm in README and CONTRIBUTING

9f39784

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

refactor: fix linting

b6be8e8

Signed-off-by: Sebastian Zett <sebastian.zett@tngtech.com>

zettseb force-pushed the upgrade branch from 50aa854 to b6be8e8 Compare June 23, 2026 16:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade all dependencies#574

Upgrade all dependencies#574
zettseb wants to merge 38 commits into
mainfrom
upgrade

zettseb commented Jun 23, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

zettseb commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Runtime & tooling

Client

Server

Tests

Not addressed

RESULT

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

zettseb commented Jun 23, 2026 •

edited

Loading