[BUG FIX] Related to issue #207 on conda_local profile#208
Draft
Mxrcon wants to merge 2 commits into
Draft
Conversation
abhi18av
requested changes
Jul 12, 2024
abhi18av
left a comment
abhi18av
left a comment
Member
There was a problem hiding this comment.
Hi @Mxrcon ,
Thank you so much for taking this initiative!
The actual changes need to be slightly different and in compliance with docker.conf https://github.com/TORCH-Consortium/MAGMA/blob/master/conf/docker.config#L8-L26
Furthermore, could you please also update the Readme accordingly?
Member
|
@Mxrcon , I've invited you to this particular repository to facilitate faster testing and improve collaboration on testing/refactors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋, Hey there Again!
I'm here to suggest a small fix to the issue previously described on #207, on the conda_local settings overlapping and letting one process fail due to incorrect conda env activation.
Feel free to make any code modifications, ask any questions or discuss those changes with me, I'll be more than happy to contribute with this pipeline that I'm an common user.
Kindly,
Davi