Reuse link_id if link is split across lines - #6703
Open
davidfokkema wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
Small patch, extra tests, no conflicts. I can merge this but I'm not sure if you want to take a look first and make changes, @willmcgugan ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with links that are split up over several lines because each segment regenerates a link ID. The patch reuses the link ID for each part of a link. Different links get their own ID, still. It fixes a problem that Battery Acid & Bubblegum was encountering: when a link wraps to the next line and you hover the mouse cursor only the part of the link on the current line is highlighted. With the fix in this PR, the complete link is highlighted, even if it extends over multiple lines.
Previously discussed on Discord: https://discord.com/channels/1026214085173461072/1026214085865504861/1540021386913775797.