fix(unicylce cleanup): defer cleanup until vehicle callbacks complete - #226
Open
florinm03 wants to merge 1 commit into
Open
fix(unicylce cleanup): defer cleanup until vehicle callbacks complete#226florinm03 wants to merge 1 commit into
florinm03 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #218.
Basically, when walking mode exits,
walk.luadoes this:The multiplayer vehicle manager then loops through all vehicles and deletes every unicycle whose ID is not
new_id.walk.luastill had the Lua variable referring to the old unicycle and called:The Lua variable still existed, but the underlying BeamNG vehicle object had already been destroyed. That produced the invalid userdata error.
The fix moves the deletion to the next update tick so that the game doesn't call non-existent objects.
Tested it on a few new restarts of the game and mod and it did not happen anymore. :)
Errors: