Skip to content

refactor(accounts): extract AccountRegistryStore state collaborator (Wave 3 / 3a-2) - #1363

Merged
mauricecarrier7 merged 1 commit into
developfrom
feat/pp-decomp-3a2-registry-store
Jul 31, 2026
Merged

refactor(accounts): extract AccountRegistryStore state collaborator (Wave 3 / 3a-2)#1363
mauricecarrier7 merged 1 commit into
developfrom
feat/pp-decomp-3a2-registry-store

Conversation

@mauricecarrier7

Copy link
Copy Markdown
Contributor

Stacked on #1361 (feat/pp-decomp-3a1-registry-cache). Merge #1361 first; this PR's diff is only the 3a-2 changes. GitHub retargets it to develop once #1361 merges.

What & why

Second of the 3a PalaceAccounts in-target collaborator splits. The account-registry state and all thread-safe access — the current hash, the [hash → [Account]] sets, the O(1) accountByUUID index kept in barrier-lockstep with them, the separate slim launch fallback, and the concurrent accountSetsLock sync-read/barrier-write primitives — move out of AccountsManager into an injected AccountRegistryStore. After this the hub holds no registry-state concurrency machinery. Behaviour-identical.

Design decisions (both architect-validated)

  • final class, not an actor. account(_:) is a synchronous @objc TPPLibraryAccountsProvider requirement, and the background-work drain choreography depends on a synchronous accountSetsLock.sync read blocking behind the barrier. An actor would force await through the @objc conformance and delete that timing. The store owns the same concurrent DispatchQueue verbatim.
  • accountSet (current hash) moves into the store so one lock still guards {currentHash, accountSets, accountByUUID}. accountsForCurrentHash() / currentBucketIsLoaded() read the hash and its bucket in one performRead — preserving the multi-field snapshot atomicity a library switch would otherwise tear. The hub facade routes accounts(nil) / accountsHaveLoaded to these atomic methods, never accounts(forKey: currentHash) (which splits the read across two lock acquisitions — caught at contract review as Finding-1).

Changes

  • New AccountRegistryStore.swift (@unchecked Sendable; the two barrier carriers move with it); index rebuilt in the same barrier as any mutation via the pure static buildAccountIndex.
  • Hub: deleted the state + performRead/performWrite/mutateAccountSets/storeSlim/slimAccount + the buildAccountIndex impl; injected registryStore via init default; retyped ~15 call sites; kept account/accounts/accountsHaveLoaded facades and a buildAccountIndex static shim (AccountsManagerAccountIndexTests calls it). @unchecked Sendable audit + drain comments refreshed to name the store.
  • The one deliberate init delta: the accountSet seed becomes store.setCurrentHash(...) after super.init(); the sync preload observes it via GCD barrier FIFO.
  • Tests: AccountRegistryStoreSeamTests — index-coherence-under-churn (_coherentSnapshot), no-torn-read, slim-isolation, deterministic current-hash correctness, torn-read robustness, and hub-delegation routing.

Verification

Gate Result
God-class LOC freeze re-baselined DOWN 2173 → 2080 (−93)
Palace-noDRM build (production compile) BUILD SUCCEEDED
Locator / shared-read / snapshot drift 304 / 213 / zero
Package-purity (store names no AppContainer/MBDC/ImageCache.shared) clean
DRM PalaceTests (incl. the concurrency suite) runs in CI — this change was authored in a git worktree whose Adobe-DRM test host can't build (dp_all.h); verified by reading, not a local run. CI must be green before merge.

Review rigor

/rigorous-fix: fix-contract → architect pre-review BLOCKED (atomicity split-read + polarity) → fixed → APPROVED → implement → 3× SoD (architect, qa_test, blast_radius). qa initially BLOCKED one over-claiming atomicity test (inert against a split-read mutant); fixed by reframing it honestly + adding a deterministic correctness test + a torn-read robustness test → all three APPROVED. Reviewers are session-spawned agents (the [Self-Approval] flag is the known false-positive), not an independent human review.

Not in this PR

carveSlimFeed (3a-1 deferral). The remaining three 3a collaborators (AuthDocumentLoader, RegistryLoader, CredentialResolver, CurrentAccountStore) are separate PRs.

🤖 Generated with Claude Code

@mauricecarrier7
mauricecarrier7 force-pushed the feat/pp-decomp-3a2-registry-store branch from c6bc8fb to 7d355fa Compare July 31, 2026 15:56
@mauricecarrier7
mauricecarrier7 changed the base branch from feat/pp-decomp-3a1-registry-cache to develop July 31, 2026 15:56
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown

🧪 Unit Test Results

📊 View Full Interactive Report

✅ ALL TESTS PASSED

8189 tests | 8051 passed | 0 failed | 136 skipped | ⏱️ 11m 23s | 📊 98.3% | 📈 44.6% coverage

All 945 classes (full matrix — click to expand)
Class Tests Passed Failed Skipped Duration
✅ AccessLintComplianceTests 11 11 0 0 199ms
✅ AccessibilityAnnouncementCenterTests 20 20 0 0 1.83s
✅ AccessibilityLabelTests 9 9 0 0 230ms
✅ AccessibilityPreferencesTests 26 26 0 0 1.07s
✅ AccessibilityServiceTests 11 11 0 0 737ms
✅ AccountAuthDocCarryoverTests 5 5 0 0 3.36s
✅ AccountAuthSurfaceHostsTests 7 7 0 0 44ms
✅ AccountAwareNetworkTests 10 10 0 0 226ms
✅ AccountDetailCredentialStateTests 7 0 0 7 382ms
✅ AccountDetailPINVisibilityTests 25 0 0 25 352ms
✅ AccountDetailSignOutConfirmationTests 2 0 0 2 48ms
✅ AccountDetailViewModelGapTests 1 1 0 0 30ms
✅ AccountDetailViewModelLeakTests 1 1 0 0 36ms
✅ AccountDetailViewModelSignedInDerivationTests 5 0 0 5 24ms
✅ AccountDetailViewModelTests 19 0 0 19 166ms
✅ AccountDetailsAuthenticationIsBrowserBasedTests 10 10 0 0 137ms
✅ AccountDetailsNeedsAuthAggregateTests 10 10 0 0 242ms
✅ AccountDetailsURLTests 17 17 0 0 492ms
✅ AccountErrorReportingTests 1 1 0 0 3ms
✅ AccountModelGapTests 9 9 0 0 333ms
✅ AccountModelTests 20 20 0 0 330ms
✅ AccountNetworkingSeamTests 2 2 0 0 30ms
✅ AccountProfileDocumentTests 3 3 0 0 30ms
✅ AccountRegistryCacheSeamTests 3 3 0 0 265ms
✅ AccountRegistryStoreSeamTests 6 6 0 0 246ms
✅ AccountScopeAdapterTests 4 4 0 0 227ms
✅ AccountStateMachineTests 13 13 0 0 965ms
✅ AccountSwitchBorrowReauthCouplingContractTests 4 4 0 0 166ms
✅ AccountSwitchCleanupTests 8 8 0 0 337ms
✅ AccountSwitchIntegrationTests 8 8 0 0 541ms
✅ AccountSwitchLifecycleTests 9 0 0 9 221ms
✅ AccountsManagerAccountIndexTests 7 7 0 0 110ms
✅ AccountsManagerAuthDocContractTests 1 1 0 0 95ms
✅ AccountsManagerCacheReadTests 4 4 0 0 393ms
✅ AccountsManagerCacheTests 16 16 0 0 176ms
✅ AccountsManagerCancellationTests 5 5 0 0 644ms
✅ AccountsManagerCatalogLoadJoinTests 3 3 0 0 1.10s
✅ AccountsManagerCurrentAccountSwitchContractTests 5 5 0 0 134ms
✅ AccountsManagerFirstRunDecodeTests 3 3 0 0 419ms
✅ AccountsManagerGapTests 3 3 0 0 90ms
✅ AccountsManagerHelpersTests 12 12 0 0 29ms
✅ AccountsManagerIsolationLintTests 4 4 0 0 1.11s
✅ AccountsManagerLaunchSnapshotTests 13 13 0 0 2.19s
✅ AccountsManagerStateMachineWiringTests 18 18 0 0 5.89s
✅ AccountsManagerTests 51 48 0 3 11.99s
✅ ActiveSessionsViewModelTests 12 12 0 0 440ms
✅ AdobeActivationTests 6 6 0 0 43ms
✅ AdobeCertificateGapTests 7 7 0 0 718ms
✅ AdobeDRMCharacterizationTests 21 21 0 0 75ms
✅ AdobeDRMErrorGapTests 3 3 0 0 5ms
✅ AdobeDRMHandlerTests 12 12 0 0 487ms
✅ AdobeDRMServiceGapTests 2 2 0 0 5ms
✅ AlertModelCoverageTests 6 6 0 0 46ms
✅ AlertModelRetryTests 7 7 0 0 13ms
✅ AlertModelTests 2 2 0 0 41ms
✅ AlertPresentationRawGuardLintTests 6 6 0 0 40ms
✅ AlertUtilsTests 20 20 0 0 446ms
✅ AnnotationContractTests 3 3 0 0 68ms
✅ AnnotationDeviceIDTests 2 2 0 0 71ms
✅ AnnotationPostResponseContractTests 1 1 0 0 5ms
✅ AnnouncementChainTests 5 5 0 0 7ms
✅ AnnouncementTests 3 3 0 0 30ms
✅ AnonymousBorrowBaselineFixtureTests 13 13 0 0 98ms
✅ AnonymousBorrowCandidateFixtureTests 6 6 0 0 22ms
✅ AnonymousBorrowDeltaTests 2 2 0 0 563ms
✅ AppContainerAudiobookFactoryTests 3 3 0 0 4ms
✅ AppContainerAuthCoordinatorRegistrationTests 3 3 0 0 4ms
✅ AppContainerImageLoaderInjectionTests 4 4 0 0 76ms
✅ AppContainerIsolationLintTests 7 7 0 0 1.68s
✅ AppContainerResetTests 5 5 0 0 89ms
✅ AppContainerTests 5 5 0 0 78ms
✅ AppContainerWithSignInModalSheetPresenterTests 2 2 0 0 72ms
✅ AppHealthViewModelTests 8 8 0 0 414ms
✅ AppLaunchTrackerExtendedTests 16 16 0 0 230ms
✅ AppLaunchTrackerTests 10 10 0 0 602ms
✅ AppLaunchTrackerWiringTests 2 2 0 0 61ms
✅ AppRatingServiceOverrideTests 3 3 0 0 132ms
✅ AppRatingServiceTests 9 9 0 0 162ms
✅ AppRouteTests 5 5 0 0 17ms
✅ AppTabHostMiniPlayerIntegrationTests 6 6 0 0 404ms
✅ AppTabHostViewBadgeCountTests 10 10 0 0 217ms
✅ AppTabRouterCoverageTests 4 4 0 0 63ms
✅ AppTabRouterGapTests 3 3 0 0 6ms
✅ ArrayExtensionsTests 6 6 0 0 281ms
✅ AudioBookmarkGapTests 6 6 0 0 150ms
✅ AudioEngineWrapperTests 8 8 0 0 339ms
✅ AudioInterruptionLogicTests 6 6 0 0 64ms
✅ AudioSessionActivatorTests 8 8 0 0 81ms
✅ AudiobookAccessibilityTests 7 7 0 0 31ms
✅ AudiobookBackgroundAudioTests 2 2 0 0 18ms
✅ AudiobookBearerTokenRecoveryTests 21 21 0 0 469ms
✅ AudiobookBookmarkBusinessLogicConcurrencyTests 3 3 0 0 181ms
✅ AudiobookBookmarkBusinessLogicPositionWriteTests 8 8 0 0 213ms
✅ AudiobookBookmarkBusinessLogicTests 21 21 0 0 4.40s
✅ AudiobookChapterTOCNormalizationTests 6 6 0 0 6ms
✅ AudiobookColdLoadRecoveryTests 4 4 0 0 477ms
✅ AudiobookContentGateTests 11 11 0 0 734ms
✅ AudiobookCrossVendorSmokeTests 4 4 0 0 78ms
✅ AudiobookDataManagerEmptyQueueTests 1 1 0 0 8ms
✅ AudiobookDataManagerErrorHandlingTests 5 5 0 0 215ms
✅ AudiobookDataManagerModelsTests 20 20 0 0 169ms
✅ AudiobookDataManagerNetworkSyncTests 5 5 0 0 113ms
✅ AudiobookDataManagerSaveTests 4 4 0 0 162ms
✅ AudiobookDataManagerStoreRecoveryTests 5 5 0 0 320ms
✅ AudiobookFileLoggerTests 15 15 0 0 590ms
✅ AudiobookFirstOpenHangTests 14 14 0 0 1.65s
✅ AudiobookLoadFailureSAMLReauthTests 10 10 0 0 459ms
✅ AudiobookLoaderDispatchTests 7 7 0 0 1.53s
✅ AudiobookLoaderFinalizeBuildTests 11 11 0 0 392ms
✅ AudiobookLoaderOPDSShapeMatrixTests 8 0 0 8 189ms
✅ AudiobookLoaderPredicateTests 11 11 0 0 124ms
✅ AudiobookLoaderTests 2 2 0 0 2.98s
✅ AudiobookMorphingPlayerViewTests 20 20 0 0 1.64s
✅ AudiobookNetworkValidationTests 3 3 0 0 6ms
✅ AudiobookOpenStateRaceTests 3 3 0 0 274ms
✅ AudiobookPhoneAlertContentTests 3 3 0 0 10ms
✅ AudiobookPlaybackStateTests 3 3 0 0 234ms
✅ AudiobookPlaybackTests 26 26 0 0 401ms
✅ AudiobookPlaytimesLifecycleTests 6 6 0 0 487ms
✅ AudiobookPositionAdapterContractTests 3 3 0 0 134ms
✅ AudiobookPositionPolicyValidatorTests 14 14 0 0 289ms
✅ AudiobookPositionRestoreTests 20 20 0 0 437ms
✅ AudiobookReadinessPlaybackContractTests 2 2 0 0 532ms
✅ AudiobookSAMLReauthTests 6 6 0 0 207ms
✅ AudiobookSessionErrorDescriptionTests 4 4 0 0 18ms
✅ AudiobookSessionErrorExtTests 4 4 0 0 9ms
✅ AudiobookSessionErrorTests 3 3 0 0 7ms
✅ AudiobookSessionManagerErrorMappingTests 6 6 0 0 122ms
✅ AudiobookSessionManagerFlagGatePresentationTests 4 4 0 0 150ms
✅ AudiobookSessionManagerPresenterMigrationTests 10 10 0 0 2.04s
✅ AudiobookSessionManagerShutdownTests 12 12 0 0 856ms
✅ AudiobookSessionPresenterLifecycleContractTests 3 3 0 0 105ms
✅ AudiobookSessionPresenterTests 31 31 0 0 191ms
✅ AudiobookSessionStateTests 6 6 0 0 27ms
✅ AudiobookSessionStateTransitionTests 22 22 0 0 430ms
✅ AudiobookSkipIntervalSettingsTests 7 7 0 0 101ms
✅ AudiobookSleepTimerIntegrationTests 5 5 0 0 244ms
✅ AudiobookStorageLocationTests 3 3 0 0 27ms
✅ AudiobookTOCTests 18 18 0 0 928ms
✅ AudiobookTimeEntryTests 6 6 0 0 12ms
✅ AudiobookTimeTrackerEdgeTests 8 8 0 0 175ms
✅ AudiobookTimeTrackerLifecycleTests 5 5 0 0 1.36s
✅ AudiobookTimeTrackerTests 9 9 0 0 656ms
✅ AudiobookTrackCompletionTests 2 2 0 0 12ms
✅ AudiobookTypeRoutingTests 5 5 0 0 124ms
✅ AudiobookVendorAdapterTests 5 5 0 0 648ms
✅ AudiobookVendorRecoveryContractTests 1 1 0 0 51ms
✅ AudiobookmarkTests 4 4 0 0 21ms
✅ AuthCoordinatorTelemetryTests 5 5 0 0 318ms
✅ AuthDecisionEventEmissionTests 7 7 0 0 19ms
✅ AuthDocumentContractTests 2 2 0 0 45ms
✅ AuthDocumentVariantsContractTests 5 5 0 0 40ms
✅ AuthErrorCategoryTests 12 12 0 0 146ms
✅ AuthErrorProblemDocSeamTests 6 6 0 0 1.05s
✅ AuthFlowSecurityTests 3 0 0 3 27ms
✅ AuthReducerTests 21 21 0 0 551ms
✅ AuthTypeTests 7 7 0 0 37ms
✅ AuthenticationTests 16 16 0 0 101ms
✅ BackgroundDownloadHandlerTests 28 28 0 0 1.67s
✅ BackgroundListenerTests 2 2 0 0 86ms
✅ BackgroundReconciliationContractTests 8 8 0 0 57ms
✅ BackgroundSessionRoutingTests 6 6 0 0 76ms
✅ BackupExclusionMigrationTests 3 3 0 0 9ms
✅ BadgeDefinitionTests 33 33 0 0 1.12s
✅ BadgeServiceTests 16 16 0 0 246ms
✅ BadgeUnlockPhaseTests 4 4 0 0 17ms
✅ BadgesViewModelTests 14 14 0 0 161ms
✅ BasicAuthEmptyCredentialTests 4 4 0 0 9ms
✅ BearerTokenAdapterTests 5 4 0 1 302ms
✅ BearerTokenFulfillFlowTests 4 4 0 0 227ms
✅ BearerTokenRefreshTests 4 4 0 0 510ms
✅ BearerTokenResponseDetectionTests 7 7 0 0 20ms
✅ BeginningPositionPolicyTests 8 8 0 0 30ms
✅ BookAvailabilityFormatterTests 18 18 0 0 711ms
✅ BookButtonMapperHoldReadyTests 10 10 0 0 110ms
✅ BookButtonMapperTests 21 21 0 0 442ms
✅ BookButtonMapperViewModelTests 18 18 0 0 86ms
✅ BookButtonStateTests 8 8 0 0 53ms
✅ BookButtonTypeMetaTests 4 4 0 0 11ms
✅ BookButtonTypeTests 13 13 0 0 114ms
✅ BookCellModelActionTests 18 18 0 0 681ms
✅ BookCellModelCacheInvalidationTests 9 9 0 0 170ms
✅ BookCellModelCachePrefetchSafetyTests 9 9 0 0 1.04s
✅ BookCellModelCacheTests 22 22 0 0 860ms
✅ BookCellModelComputedPropertyTests 19 19 0 0 273ms
✅ BookCellModelOfflineTests 9 9 0 0 273ms
✅ BookCellModelRegistryBindingTests 4 4 0 0 1.74s
✅ BookCellModelStateTests 16 16 0 0 284ms
✅ BookCellModelStreamingHTMLTests 2 2 0 0 312ms
✅ BookCellStateComprehensiveTests 14 14 0 0 192ms
✅ BookContentResetServiceTests 2 2 0 0 12ms
✅ BookDetailMetadataHydrationTests 6 6 0 0 1.59s
✅ BookDetailMetadataMergeContractTests 5 5 0 0 550ms
✅ BookDetailOpenRoutingTests 3 3 0 0 119ms
✅ BookDetailViewModelAudiobookDismissTests 1 1 0 0 36ms
✅ BookDetailViewModelTests 91 91 0 0 5.23s
✅ BookFileManagerAccountScopingTests 5 5 0 0 184ms
✅ BookFileManagerSideloadResolutionTests 4 4 0 0 597ms
✅ BookFileManagerTests 8 8 0 0 64ms
✅ BookListViewAccessibilityTests 9 9 0 0 68ms
✅ BookPreviewTests 4 4 0 0 57ms
✅ BookRegistryStoreTests 26 26 0 0 636ms
✅ BookRegistrySyncReadinessTests 4 3 0 1 553ms
✅ BookRegistrySyncReentrancyTests 6 6 0 0 3.40s
✅ BookRegistrySyncSideloadExemptionTests 2 0 0 2 94ms
✅ BookRegistrySyncTests 36 31 0 5 1.08s
✅ BookReturnCleverReauthTests 1 1 0 0 166ms
✅ BookReturnServiceAuthCoordinatorTests 3 3 0 0 530ms
✅ BookReturnServiceContractTests 9 9 0 0 3.33s
✅ BookReturnServiceTests 18 18 0 0 945ms
✅ BookServiceAudiobookOpenTests 2 2 0 0 128ms
✅ BookSignInRedirectHandlerTests 8 8 0 0 223ms
✅ BookStateIntegrationTests 8 8 0 0 275ms
✅ BookmarkBusinessLogicExtendedTests 6 6 0 0 403ms
✅ BookmarkDeletionLogTests 3 3 0 0 1.70s
✅ BookmarkDeviceIdMatchingTests 3 3 0 0 253ms
✅ BookmarkExistenceTests 4 4 0 0 296ms
✅ BookmarkManagerTests 24 24 0 0 934ms
✅ BookmarkSortingTests 1 1 0 0 52ms
✅ BookmarkSyncTests 3 3 0 0 108ms
✅ BorrowAndDownloadIntegrationTests 7 7 0 0 459ms
✅ BorrowErrorMessageTests 13 13 0 0 360ms
✅ BorrowErrorPresenterTests 6 6 0 0 80ms
✅ BorrowOperationAuthCoordinatorTests 6 6 0 0 578ms
✅ BorrowOperationCleverReauthTests 2 2 0 0 70ms
✅ BorrowOperationContractTests 8 8 0 0 3.28s
✅ BorrowOperationStreamingHTMLTests 3 3 0 0 32ms
✅ BorrowOperationTests 13 13 0 0 399ms
✅ BorrowOperationTimeoutTests 3 3 0 0 113ms
✅ BorrowReauthResettingTests 4 4 0 0 945ms
✅ BorrowReducerContractTests 2 2 0 0 106ms
✅ BorrowReducerCoreContractTests 12 12 0 0 353ms
✅ BorrowReducerTests 21 21 0 0 570ms
✅ BundledRegistrySnapshotTests 5 5 0 0 228ms
✅ ButtonStateMonotonicClampTests 10 10 0 0 1.68s
✅ ButtonStateTests 16 16 0 0 203ms
✅ ButtonStyleTypeTests 2 2 0 0 822ms
✅ C64ConversionTests 6 6 0 0 13ms
✅ CarPlayAudiobookBridgePresenterMigrationTests 2 2 0 0 8ms
✅ CarPlayAuthHelperReadinessTests 3 3 0 0 276ms
✅ CarPlayChapterListTests 3 3 0 0 105ms
✅ CarPlayIntegrationTests 2 2 0 0 14ms
✅ CarPlayLibraryRefreshTests 3 3 0 0 10ms
✅ CarPlayNowPlayingTemplateTests 4 4 0 0 531ms
✅ CarPlayOpenAppAlertTests 6 6 0 0 70ms
✅ CarPlayPlaybackErrorTests 8 8 0 0 154ms
✅ CarPlayTests 12 12 0 0 207ms
✅ CarPlayTimeTrackingTests 3 3 0 0 1.10s
✅ CatalogAPIDedupeTests 3 3 0 0 434ms
✅ CatalogAPIEntryPointTests 1 1 0 0 3ms
✅ CatalogAccessibilityTests 8 8 0 0 49ms
✅ CatalogCacheKeyAndIsolationTests 12 12 0 0 254ms
✅ CatalogCacheMetadataExactBoundaryTests 4 4 0 0 7ms
✅ CatalogCacheMetadataTests 21 21 0 0 5.07s
✅ CatalogCrawlSchedulerTests 9 9 0 0 1.63s
✅ CatalogFeedModelTests 4 4 0 0 61ms
✅ CatalogFilterGroupModelTests 17 17 0 0 117ms
✅ CatalogFilterModelTests 17 17 0 0 716ms
✅ CatalogFilterServiceTests 29 29 0 0 897ms
✅ CatalogFilterTests 1 1 0 0 <1ms
✅ CatalogLaneAssemblyTests 7 7 0 0 44ms
✅ CatalogLaneModelStructTests 20 20 0 0 200ms
✅ CatalogLaneModelTests 3 3 0 0 89ms
✅ CatalogLaneMoreFilterStateTests 8 8 0 0 337ms
✅ CatalogLaneMoreViewModelTests 43 43 0 0 8.68s
✅ CatalogLaneRowViewAccessibilityTests 11 11 0 0 156ms
✅ CatalogLaneSortingTests 5 5 0 0 92ms
✅ CatalogLoadIntegrationTests 6 6 0 0 1.07s
✅ CatalogOPDS2NegotiationTests 12 12 0 0 125ms
✅ CatalogPreloaderTests 6 6 0 0 351ms
✅ CatalogProblemDocumentTests 6 6 0 0 231ms
✅ CatalogRepositoryCoreTests 9 9 0 0 470ms
✅ CatalogRepositoryStaleWhileRevalidateTests 12 12 0 0 244ms
✅ CatalogRepositoryTests 19 19 0 0 521ms
✅ CatalogSearchViewModelRegistryUpdateTests 5 5 0 0 220ms
✅ CatalogSearchViewModelTests 67 67 0 0 7.67s
✅ CatalogSelectorsTests 2 2 0 0 10ms
✅ CatalogSortServiceTests 14 14 0 0 1.10s
✅ CatalogStateTests 7 7 0 0 116ms
✅ CatalogViewContinueRowsIntegrationTests 3 3 0 0 3.31s
✅ CatalogViewLibraryIconTests 2 2 0 0 63ms
✅ CatalogViewModelStateMachineTests 19 19 0 0 1.04s
✅ ChaosFaultInjectionTests 5 5 0 0 1.53s
✅ ChapterChangeDetectorTests 5 5 0 0 126ms
✅ ChapterTOCNormalizerTests 7 7 0 0 440ms
✅ CirculationAnalyticsTests 4 4 0 0 22ms
✅ ColdStartResumeIntegrationTests 10 10 0 0 1.55s
✅ ColorExtensionTests 5 5 0 0 55ms
✅ ConcurrentBookStateTests 3 3 0 0 23ms
✅ ConcurrentDownloadStateTests 3 3 0 0 23ms
✅ ConcurrentTokenRefreshTests 2 2 0 0 122ms
✅ ContinueRowSectionTests 6 6 0 0 28ms
✅ ContinuousPlaybackTrackingTests 3 3 0 0 636ms
✅ CookiePersistenceTests 10 10 0 0 3.40s
✅ CrawlStateTests 16 16 0 0 137ms
✅ CrawlableFeedAnalysisTests 17 17 0 0 57ms
✅ CrawlerFallbackTests 12 12 0 0 317ms
✅ CredentialEdgeCaseTests 6 6 0 0 290ms
✅ CredentialPrivacyTests 4 4 0 0 24ms
✅ CredentialPromptCoordinatorTests 4 4 0 0 347ms
✅ CredentialSnapshotInvalidationTests 5 0 0 5 153ms
✅ CredentialStoreCharacterizationTests 7 7 0 0 770ms
✅ CrossDeviceBookmarkSyncTests 12 12 0 0 214ms
✅ CrossDeviceSyncE2ETests 8 8 0 0 745ms
✅ CrossDomain401Tests 8 8 0 0 435ms
✅ CrossFormatMappingTests 14 14 0 0 131ms
✅ DPLAErrorTests 3 3 0 0 89ms
✅ DRMAdversarialTests 4 1 0 3 25ms
✅ DRMFulfilledPublicationTests 6 6 0 0 19ms
✅ DataBase64Tests 3 3 0 0 9ms
✅ DataReceptionComparisonTests 2 2 0 0 65ms
✅ DateExtensionTests 9 9 0 0 21ms
✅ DateFormattingTests 4 4 0 0 324ms
✅ Date_NYPLAdditionsTests 7 7 0 0 459ms
✅ DebugSettingsForceSkeletonsTests 4 4 0 0 22ms
✅ DebugSettingsGapTests 4 4 0 0 46ms
✅ DebugSettingsTests 31 31 0 0 470ms
✅ DefaultCatalogAPITests 31 31 0 0 1.58s
✅ DefaultRecentlyReadingServiceTests 13 13 0 0 207ms
✅ DeriveInitialStateTests 4 4 0 0 152ms
✅ DeveloperSettingsEngineeringTierTests 4 4 0 0 30ms
✅ DeveloperSettingsViewModelOverrideTests 3 0 0 3 34ms
✅ DeviceLogCollectorGapTests 2 2 0 0 247ms
✅ DeviceLogCollectorTests 13 13 0 0 1.12s
✅ DeviceOrientationTests 7 7 0 0 67ms
✅ DeviceSpecificErrorMonitorTests 11 11 0 0 38ms
✅ DictionaryExtensionsTests 5 5 0 0 11ms
✅ DiskBudgetManagerTests 7 7 0 0 76ms
✅ DiskBudgetTests 2 2 0 0 10ms
✅ DownloadAccountContextAdapterTests 11 11 0 0 137ms
✅ DownloadAlertPresenterTests 8 8 0 0 189ms
✅ DownloadAnnouncementServiceTests 12 12 0 0 131ms
✅ DownloadAuthRetryHandlerAuthCoordinatorTests 6 6 0 0 3.56s
✅ DownloadAuthRetryHandlerTaskLifecycleTests 4 4 0 0 669ms
✅ DownloadAuthRetryHandlerTests 17 17 0 0 2.50s
✅ DownloadCancellationHandlerTests 5 5 0 0 148ms
✅ DownloadCompleteMomentTests 6 6 0 0 49ms
✅ DownloadCompletionParserTests 9 9 0 0 311ms
✅ DownloadCoordinatorIntegrationTests 10 10 0 0 5.94s
✅ DownloadCoordinatorTests 11 11 0 0 57ms
✅ DownloadDiskSpaceTests 2 2 0 0 4ms
✅ DownloadErrorInfoTests 3 3 0 0 11ms
✅ DownloadErrorRecoveryPolicyTests 11 11 0 0 2.81s
✅ DownloadErrorRecoveryTests 3 3 0 0 262ms
✅ DownloadFreeSpaceExhaustionTests 11 11 0 0 201ms
✅ DownloadInfoTests 5 5 0 0 6ms
✅ DownloadIntegrityTests 10 10 0 0 124ms
✅ DownloadOnlyOnWiFiTests 10 10 0 0 600ms
✅ DownloadPersistenceStoreTests 5 5 0 0 44ms
✅ DownloadProgressPublisherCoreTests 19 19 0 0 2.24s
✅ DownloadProgressPublisherTests 2 2 0 0 9ms
✅ DownloadQueueIntegrationTests 3 3 0 0 77ms
✅ DownloadQueueOrchestratorTests 9 9 0 0 198ms
✅ DownloadRMSDKHandoffTests 1 1 0 0 3ms
✅ DownloadReconciliationLaunchOrderContractTests 2 2 0 0 44ms
✅ DownloadReconciliationTests 17 17 0 0 156ms
✅ DownloadRedirectTests 7 7 0 0 48ms
✅ DownloadResumeAfterKillTests 7 7 0 0 659ms
✅ DownloadSlotManagementTests 5 5 0 0 220ms
✅ DownloadStartCoordinatorContractTests 5 5 0 0 191ms
✅ DownloadStartCoordinatorTests 9 9 0 0 790ms
✅ DownloadStartDispatcherContractTests 12 12 0 0 363ms
✅ DownloadStartDispatcherTests 26 26 0 0 172ms
✅ DownloadStartReducerContractTests 24 24 0 0 1.66s
✅ DownloadStateMachineIntegrationTests 15 15 0 0 117ms
✅ DownloadStateMachineTests 5 5 0 0 33ms
✅ DownloadStateManagerTests 16 16 0 0 263ms
✅ DownloadTaskLifecycleServiceTests 9 9 0 0 348ms
✅ DownloadTaskPersistenceTests 14 14 0 0 166ms
✅ DownloadThrottlingContractTests 2 2 0 0 6ms
✅ DownloadThrottlingServiceTests 10 10 0 0 326ms
✅ DownloadTransferRetryTests 6 6 0 0 2.17s
✅ DownloadWatchdogTests 3 3 0 0 57ms
✅ EPUBKeyCommandsPP4289Tests 4 4 0 0 15ms
✅ EPUBModuleTests 4 4 0 0 107ms
✅ EPUBPositionTests 10 10 0 0 259ms
✅ EPUBSearchViewModelTests 18 18 0 0 2.35s
✅ EPUBToolbarToggleTests 11 11 0 0 86ms
✅ EffectBoundaryTests 6 6 0 0 92ms
✅ EmailAddressTests 16 16 0 0 145ms
✅ EpubSampleFactoryTests 5 5 0 0 100ms
✅ ErrorActivityTrackerTests 12 12 0 0 170ms
✅ ErrorDetailTests 14 14 0 0 231ms
✅ ErrorDetailViewControllerGapTests 3 3 0 0 177ms
✅ ErrorDetailViewControllerTests 14 14 0 0 168ms
✅ ErrorLogExporterTests 5 5 0 0 980ms
✅ ExecutorNetworkHermeticityTests 1 1 0 0 109ms
✅ ExpiredLoanStringsTests 5 5 0 0 658ms
✅ FacetEnumTests 3 3 0 0 2ms
✅ FacetToolbarAccessibilityTests 5 5 0 0 60ms
✅ FacetViewModelLogoDelegateTests 4 4 0 0 17ms
✅ FacetViewModelTests 18 18 0 0 2.15s
✅ FetchManifestWithBearerTokenLCPSafetyTests 1 1 0 0 6ms
✅ FetchManifestWithBearerTokenTests 9 9 0 0 136ms
✅ FetchOpenAccessManifestLCPSafetyTests 4 4 0 0 9ms
✅ FileURLGenerationTests 3 3 0 0 9ms
✅ FindawayChapterStatusGuardTests 1 1 0 0 2ms
✅ FindawaySavedVsPlayedTests 1 1 0 0 34ms
✅ FloatTPPAdditionsTests 5 5 0 0 98ms
✅ FocusIndicationTests 7 7 0 0 174ms
✅ FontManagerTests 17 17 0 0 482ms
✅ ForceResetTests 6 6 0 0 74ms
✅ GeneralCacheClearOnUpdateTests 3 3 0 0 17ms
✅ GeneralCacheTests 20 20 0 0 538ms
✅ GroupEnumTests 1 1 0 0 7ms
✅ HTMLTextViewTests 70 70 0 0 15.48s
✅ HoldNotificationClassificationTests 2 2 0 0 19ms
✅ HoldsBadgeCountTests 9 9 0 0 33ms
✅ HoldsBookViewModelTests 8 8 0 0 683ms
✅ HoldsReducerTests 11 11 0 0 466ms
✅ HoldsSyncFailureTests 12 12 0 0 557ms
✅ HoldsViewModelTests 23 23 0 0 2.14s
✅ HostFailureTrackerTests 2 2 0 0 28ms
✅ ImageCacheContinuationTests 1 1 0 0 75ms
✅ ImageCacheOffMainIsolationTests 2 2 0 0 799ms
✅ ImageCacheTypeTests 1 1 0 0 1ms
✅ ImageCoverKeyUnificationTests 2 2 0 0 3ms
✅ ImageLoaderTests 14 14 0 0 1.19s
✅ InflightFeedFetchesTimeoutTests 4 4 0 0 10.31s
✅ IntExtensionsTests 4 4 0 0 45ms
✅ IsReaderActiveTrackingModifierTests 4 4 0 0 96ms
✅ KeyboardNavigationFKATests 11 11 0 0 96ms
✅ KeyboardNavigationHandlerTests 16 16 0 0 146ms
✅ KeyboardVoiceOverTests 5 5 0 0 85ms
✅ LCPAcquisitionPredicateTests 4 4 0 0 60ms
✅ LCPAdapterTests 8 8 0 0 44.75s
✅ LCPAudiobookURLSchemeTests 4 4 0 0 5ms
✅ LCPAudiobooksTests 21 21 0 0 592ms
✅ LCPBotanCRLGuardTests 5 5 0 0 169ms
✅ LCPCharacterizationTests 31 31 0 0 274ms
✅ LCPClientTests 9 9 0 0 428ms
✅ LCPFulfillmentHandlerTests 8 8 0 0 431ms
✅ LCPKeychainMigrationTests 3 3 0 0 403ms
✅ LCPLibraryServiceTests 20 20 0 0 632ms
✅ LCPLicenseDocumentDetectionTests 5 5 0 0 176ms
✅ LCPLicenseFilePathTests 3 3 0 0 8ms
✅ LCPOrphanedDownloadRegistryTests 4 4 0 0 14ms
✅ LCPPDFAcquisitionPredicateTests 5 5 0 0 121ms
✅ LCPPDFDiskExtractTests 5 5 0 0 258ms
✅ LCPPDFOpenProgressTests 13 13 0 0 130ms
✅ LCPPassphraseReadinessTests 2 2 0 0 46ms
✅ LCPSessionIdentifierTests 3 3 0 0 91ms
✅ LegacySAMLProblemDocumentPropagationTests 7 7 0 0 337ms
✅ LibrariesSectionViewModelTests 16 16 0 0 46.20s
✅ LibraryCatalogMergerTests 9 9 0 0 133ms
✅ LibraryRegistryCrawlerTests 15 15 0 0 121ms
✅ LicensesServiceTests 4 4 0 0 16ms
✅ LiveCrawlableParsingTest 4 0 0 4 43ms
✅ LoanEvictionPolicyTests 13 13 0 0 37ms
✅ LoanRenewalServiceTests 9 9 0 0 1.61s
✅ LocalBookContentServiceTests 7 7 0 0 70ms
✅ LocalFileAdapterTests 6 5 0 1 209ms
✅ LogTests 13 13 0 0 843ms
✅ LoginKeyboardTests 8 8 0 0 1.10s
✅ MainActorHelpersTests 22 22 0 0 602ms
✅ MappedCatalogBridgeTests 3 3 0 0 164ms
✅ MappedCatalogModelTests 11 11 0 0 319ms
✅ MockBackendExpiredCredentialsTests 3 3 0 0 327ms
✅ MockBackendHoldsTests 3 3 0 0 74ms
✅ MockBackendIntegrationTests 4 4 0 0 278ms
✅ MockBackendLoanLimitTests 2 2 0 0 275ms
✅ MockBackendRouteMatchingTests 4 4 0 0 53ms
✅ MockBackendServerDownTests 1 1 0 0 928ms
✅ MockIsolationLintTests 5 5 0 0 1.87s
✅ MultiLibraryTokenIsolationTests 14 14 0 0 2.24s
✅ MyBooksDownloadCenterAccountIdThreadingTests 7 7 0 0 208ms
✅ MyBooksDownloadCenterAccountScopeSeamTests 3 3 0 0 34ms
✅ MyBooksDownloadCenterAdeptGapTests 3 3 0 0 30ms
✅ MyBooksDownloadCenterConcurrencyTests 22 22 0 0 671ms
✅ MyBooksDownloadCenterEvictionTests 7 7 0 0 102ms
✅ MyBooksDownloadCenterOfflineTests 8 8 0 0 239ms
✅ MyBooksDownloadSessionInvalidationTests 3 3 0 0 20ms
✅ MyBooksSimplifiedBearerTokenTests 17 17 0 0 518ms
✅ MyBooksViewModelBooksPublisherTests 3 3 0 0 67ms
✅ MyBooksViewModelConcurrencyTests 4 4 0 0 49ms
✅ MyBooksViewModelDownloadStateTests 3 3 0 0 102ms
✅ MyBooksViewModelEmptyArrayTests 3 3 0 0 4ms
✅ MyBooksViewModelEmptyStateTests 4 4 0 0 25ms
✅ MyBooksViewModelExtendedTests 15 15 0 0 243ms
✅ MyBooksViewModelFacetIntegrationTests 4 4 0 0 17ms
✅ MyBooksViewModelFacetPublisherTests 5 5 0 0 49ms
✅ MyBooksViewModelFilterSortInteractionTests 2 2 0 0 9ms
✅ MyBooksViewModelFilterTests 9 9 0 0 209ms
✅ MyBooksViewModelGuardConditionsTests 2 2 0 0 16ms
✅ MyBooksViewModelLargeDatasetTests 2 2 0 0 229ms
✅ MyBooksViewModelLoadAccountTests 2 2 0 0 273ms
✅ MyBooksViewModelLoginStateTests 4 4 0 0 349ms
✅ MyBooksViewModelMultipleAuthorSortingTests 3 3 0 0 16ms
✅ MyBooksViewModelNotificationTests 4 4 0 0 332ms
✅ MyBooksViewModelOfflineFilteringTests 3 3 0 0 101ms
✅ MyBooksViewModelPublisherTests 7 7 0 0 2.56s
✅ MyBooksViewModelSearchEdgeCaseTests 6 6 0 0 300ms
✅ MyBooksViewModelSearchQueryTests 3 3 0 0 48ms
✅ MyBooksViewModelSortPersistenceTests 3 3 0 0 31ms
✅ MyBooksViewModelSortingIntegrationTests 5 5 0 0 34ms
✅ MyBooksViewModelSortingTests 6 6 0 0 75ms
✅ MyBooksViewModelStateTransitionTests 3 3 0 0 365ms
✅ MyBooksViewModelUIBindingTests 3 3 0 0 108ms
✅ NSErrorAdditionsTests 7 7 0 0 233ms
✅ NSNotificationTPPTests 3 3 0 0 1.70s
✅ NavigationCoordinatorTests 18 18 0 0 137ms
✅ NavigationFreezePreventionTests 5 5 0 0 197ms
✅ NetworkCacheClearRoutingTests 3 3 0 0 156ms
✅ NetworkExecutorCredentialGuardTests 8 8 0 0 171ms
✅ NetworkExecutorResponseRegressionTests 4 4 0 0 98ms
✅ NetworkExecutorTaskTypeTests 3 3 0 0 70ms
✅ NetworkOfflineDetectionTests 3 3 0 0 11ms
✅ NetworkQueueTests 11 11 0 0 921ms
✅ NetworkRequestQueueTests 2 2 0 0 10.12s
✅ NetworkRetryLogicTests 7 7 0 0 102ms
✅ NetworkTimeoutTests 2 2 0 0 1ms
✅ NotificationEventTypeContractTests 7 7 0 0 57ms
✅ NotificationPayloadContractTests 10 10 0 0 41ms
✅ NotificationServiceStateMachineTests 9 9 0 0 1.32s
✅ NotificationServiceTests 16 16 0 0 305ms
✅ NotificationServiceTokenTests 13 13 0 0 139ms
✅ NotificationSyncThrottleTests 5 5 0 0 80ms
✅ NotificationTokenDataTests 4 4 0 0 38ms
✅ NotificationTokenRegistrationTests 10 10 0 0 26ms
✅ NowPlayingCoordinatorBackgroundTests 6 6 0 0 922ms
✅ NowPlayingCoordinatorTests 19 19 0 0 2.45s
✅ OAuthSAMLRedirectRegressionTests 4 4 0 0 979ms
✅ OIDCAuthDocumentParsingTests 4 4 0 0 134ms
✅ OIDCAuthTypeTests 5 5 0 0 44ms
✅ OIDCAuthenticationPropertyTests 8 8 0 0 388ms
✅ OIDCCallbackEdgeCaseTests 9 9 0 0 601ms
✅ OIDCCallbackHandlingTests 5 5 0 0 314ms
✅ OIDCCallbackSchemeTests 3 3 0 0 87ms
✅ OIDCIsolationRegressionTests 6 6 0 0 976ms
✅ OIDCLoginRoutingTests 3 3 0 0 137ms
✅ OIDCMakeRequestTests 3 3 0 0 182ms
✅ OIDCNSCodingTests 1 1 0 0 112ms
✅ OIDCNetworkLayer401Tests 5 5 0 0 1.91s
✅ OIDCReauthOnExpiredTokenTests 5 5 0 0 372ms
✅ OIDCRedirectURIConstructionTests 6 6 0 0 1.70s
✅ OIDCRegressionTests 9 9 0 0 526ms
✅ OIDCSelectedAuthenticationTests 2 2 0 0 391ms
✅ OIDCSignOutRegressionTests 6 6 0 0 1.89s
✅ OIDCTokenRefreshRegressionTests 6 6 0 0 367ms
✅ OIDCUpdateUserAccountTests 5 5 0 0 258ms
✅ OIDCViewModelRegressionTests 1 1 0 0 162ms
✅ OIDCViewModelSignInTests 2 2 0 0 4ms
✅ OPDS1BorrowEntryContractTests 4 4 0 0 45ms
✅ OPDS1CatalogGroupedContractTests 3 3 0 0 70ms
✅ OPDS1HoldEntriesContractTests 4 4 0 0 17ms
✅ OPDS1LoansFeedContractTests 6 6 0 0 39ms
✅ OPDS1ParsingTests 34 34 0 0 304ms
✅ OPDS1RevokeResponseContractTests 2 2 0 0 16ms
✅ OPDS2AuthenticationDocumentTests 18 18 0 0 91ms
✅ OPDS2AvailabilityTests 4 4 0 0 6ms
✅ OPDS2BookBridgeTests 44 44 0 0 2.35s
✅ OPDS2BorrowResponseContractTests 3 3 0 0 563ms
✅ OPDS2CatalogWiringTests 21 21 0 0 585ms
✅ OPDS2CatalogsFeedTests 3 3 0 0 216ms
✅ OPDS2ContributorTests 2 2 0 0 65ms
✅ OPDS2EmptyFeedContractTests 1 1 0 0 2ms
✅ OPDS2FeedContractTests 4 4 0 0 45ms
✅ OPDS2FeedParsingTests 11 11 0 0 318ms
✅ OPDS2FeedTests 14 14 0 0 339ms
✅ OPDS2FullMetadataTests 4 4 0 0 53ms
✅ OPDS2FullPublicationTests 13 13 0 0 197ms
✅ OPDS2IntegrationTests 18 18 0 0 717ms
✅ OPDS2LinkArrayTests 5 5 0 0 174ms
✅ OPDS2LinkComputedPropertyTests 20 20 0 0 538ms
✅ OPDS2LinkRelTests 1 1 0 0 2ms
✅ OPDS2LinkTests 2 2 0 0 55ms
✅ OPDS2ParsingTests 38 38 0 0 367ms
✅ OPDS2PublicationExtendedTests 53 53 0 0 2.60s
✅ OPDS2PublicationImageTests 6 6 0 0 120ms
✅ OPDS2PublicationNarratorTests 3 3 0 0 7ms
✅ OPDS2PublicationTests 2 2 0 0 68ms
✅ OPDS2SamlIDPTests 6 6 0 0 9ms
✅ OPDS2SearchResultsContractTests 3 3 0 0 32ms
✅ OPDS2SubjectTests 2 2 0 0 64ms
✅ OPDS2SupportingTypesTests 5 5 0 0 217ms
✅ OPDSAcquisitionPathExpandedTests 15 15 0 0 318ms
✅ OPDSFeedCacheTests 14 14 0 0 344ms
✅ OPDSFeedMigrationTests 11 11 0 0 31ms
✅ OPDSFeedParsingTests 2 2 0 0 66ms
✅ OPDSFeedServiceStateMachineTests 3 3 0 0 202ms
✅ OPDSFeedServiceTests 2 2 0 0 7ms
✅ OPDSFormatTests 13 13 0 0 61ms
✅ OPDSParserCoreTests 4 4 0 0 49ms
✅ OPDSParserTests 4 4 0 0 7ms
✅ OPDSParsingTests 57 57 0 0 2.91s
✅ OfflineActionTests 29 29 0 0 138ms
✅ OfflineQueueCoordinatorTests 11 11 0 0 85ms
✅ OfflineQueueServiceExtendedTests 13 13 0 0 543ms
✅ OfflineQueueServiceTests 17 17 0 0 307ms
✅ OpenAccessAdapterTests 13 13 0 0 87ms
✅ OverdriveDeferredFulfillmentTests 6 6 0 0 97ms
✅ OverdriveDownloadHandlerTests 9 9 0 0 712ms
✅ OverdriveFulfillmentTests 25 24 0 1 379ms
✅ PDFExtensionsTests 20 20 0 0 336ms
✅ PDFKitThumbnailProviderTests 5 5 0 0 190ms
✅ PDFReaderTests 12 12 0 0 65ms
✅ PDFSearchEmptyStateTests 4 4 0 0 5ms
✅ PP3596RegressionTests 3 3 0 0 328ms
✅ Palace 2 2 0 0 <1ms
✅ PalaceCheckPropertyTests 8 8 0 0 188ms
✅ PalaceErrorCategoryTests 20 20 0 0 139ms
✅ PalaceErrorExtendedTests 23 23 0 0 3.63s
✅ PalaceErrorTests 11 11 0 0 472ms
✅ PalaceHapticTests 4 4 0 0 22ms
✅ PalaceMotionTests 11 11 0 0 31ms
✅ PalacePDFViewTests 12 12 0 0 345ms
✅ PalacePreferencesSettingsRoundTripTests 9 9 0 0 140ms
✅ PalacePressableButtonStyleTests 6 6 0 0 5.28s
✅ PalaceTestSetupObservationTests 4 4 0 0 81ms
✅ PalaceWiringTestCaseTests 4 4 0 0 135ms
✅ ParserFuzzTests 4 4 0 0 19.25s
✅ PatronProfileContractTests 4 4 0 0 53ms
✅ PerformanceMonitorTests 14 14 0 0 402ms
✅ PerformanceReportTests 14 14 0 0 108ms
✅ PersistentLoggerTests 9 9 0 0 1.84s
✅ PlaybackBootstrapperAudioSessionTests 2 2 0 0 144ms
✅ PlaybackBootstrapperTests 8 8 0 0 1.13s
✅ PlaybackFailureRecordTests 5 5 0 0 5ms
✅ PlaybackOpenPolicyTests 7 7 0 0 7ms
✅ PlaybackRateTests 18 18 0 0 2.26s
✅ PlaybackTrackingRegressionTests 5 5 0 0 374ms
⚠️ PoolResponsivenessProbeTests 5 4 0 0 2.74s
✅ PositionPersistenceLogicTests 6 6 0 0 21ms
✅ PositionPersistenceTests 2 2 0 0 5ms
✅ PositionSyncServiceTests 13 13 0 0 428ms
✅ PositionSyncTests 5 5 0 0 55ms
✅ PositionWriterContractTests 6 6 0 0 241ms
✅ PostUpdateMigrationTests 5 5 0 0 105ms
✅ ProblemDocumentContractTests 4 4 0 0 61ms
✅ ProblemDocumentLoanExpiryTests 5 5 0 0 119ms
✅ ProblemDocumentTests 12 12 0 0 83ms
✅ ProblemReportEmailTests 8 8 0 0 19ms
✅ RatingCardMotionGateTests 5 5 0 0 328ms
✅ RatingEligibilityPolicyTests 17 17 0 0 257ms
✅ RatingEngagementTrackerTests 9 9 0 0 392ms
✅ RatingFeedbackPresenterTests 3 3 0 0 33ms
✅ RatingPromptPresenterTests 15 15 0 0 219ms
✅ ReachabilityTests 10 10 0 0 202ms
✅ Reader2BookmarkContractTests 3 3 0 0 196ms
✅ Reader2PositionAdapterContractTests 4 3 0 1 323ms
✅ Reader2PositionResumeContractTests 3 3 0 0 151ms
✅ ReaderAccessibilityTests 7 7 0 0 74ms
✅ ReaderChromeToggleFadeTests 3 3 0 0 40ms
✅ ReaderEditingActionsTests 5 5 0 0 36ms
✅ ReaderErrorTests 5 5 0 0 11ms
✅ ReaderNavBarVoiceOverTests 2 2 0 0 19ms
✅ ReaderServicePDFRouteTests 3 3 0 0 50ms
✅ ReaderServiceSyncTests 3 3 0 0 79ms
✅ ReaderThemeTests 24 24 0 0 113ms
✅ ReadingPositionTests 22 22 0 0 249ms
✅ ReadingSessionTrackerTests 13 13 0 0 141ms
✅ ReadingStatsServiceTests 12 12 0 0 338ms
✅ ReadingStatsStoreTests 9 9 0 0 329ms
✅ RedirectHandlingIntegrationTests 4 4 0 0 323ms
✅ RedirectPolicyTests 9 9 0 0 87ms
✅ RegistryDownloadServicingSeamTests 2 2 0 0 42ms
✅ RegistryFileRecoveryTests 23 23 0 0 154ms
✅ RemoteFeatureFlagsGapTests 4 4 0 0 48ms
✅ RemoteFeatureFlagsSideLoadingTests 5 5 0 0 46ms
✅ RemoteFeatureFlagsTests 21 21 0 0 698ms
✅ ResourcePropertiesLengthTests 3 3 0 0 5ms
✅ RetryClassificationTests 17 17 0 0 25ms
✅ ReturnFlowTests 1 1 0 0 2ms
✅ ReturnReducerContractTests 16 16 0 0 105ms
✅ RightsManagementDetectionTests 5 5 0 0 485ms
✅ RightsManagementDispatchContractTests 8 8 0 0 1.82s
✅ RightsManagementDispatcherTests 10 10 0 0 414ms
✅ RuntimeQuiescenceGateTests 11 10 0 1 1.32s
✅ RuntimeQuiescenceLintTests 5 5 0 0 1.22s
✅ SAMLCookieSyncTests 5 5 0 0 50ms
✅ SAMLLogoutCallbackDetectionTests 4 4 0 0 50ms
✅ SAMLLogoutLinkParsingTests 5 5 0 0 733ms
✅ SAMLLogoutURLTests 4 4 0 0 7ms
✅ SAMLPlusBiblioBoardExpirationTests 8 8 0 0 372ms
✅ SEMigrationsTests 6 6 0 0 202ms
✅ SafeDictionaryTests 21 21 0 0 75ms
✅ SamplePlayerErrorTests 5 5 0 0 98ms
✅ SampleTypeTests 8 8 0 0 12ms
✅ SceneDelegateTests 1 1 0 0 2ms
✅ ScopedResetTests 9 9 0 0 654ms
✅ SearchAccessibilityTests 11 11 0 0 18ms
✅ SearchFlowIntegrationTests 8 8 0 0 115ms
✅ SettingsViewModelComputedPropertyTests 6 6 0 0 193ms
✅ SettingsViewModelEdgeCaseTests 7 7 0 0 153ms
✅ SettingsViewModelGapTests 1 1 0 0 8ms
✅ SettingsViewModelSyncTests 14 14 0 0 370ms
✅ SettingsViewModelTests 33 33 0 0 498ms
✅ SideloadBoundaryTests 6 6 0 0 327ms
✅ SideloadImportContractTests 1 1 0 0 74ms
✅ SideloadedBookManagerTests 17 17 0 0 552ms
✅ SideloadedBookRegistryTests 14 14 0 0 215ms
✅ SideloadedLaneBridgeTests 6 6 0 0 17ms
✅ SideloadedLaneViewModelTests 7 7 0 0 161ms
✅ SignInFormPresentationTests 3 3 0 0 76ms
✅ SignInModalLifecycleTests 9 9 0 0 212ms
✅ SignInModalPredicateTests 3 3 0 0 4ms
✅ SignInModalSAMLOIDCTests 6 6 0 0 90ms
✅ SignInOAuthErrorPropagationTests 8 8 0 0 983ms
✅ SignInRequestServiceCharacterizationTests 11 11 0 0 1.23s
✅ SignInToReadFlowIntegrationTests 5 5 0 0 1.39s
✅ SignInWebSheetIntegrationTests 3 3 0 0 3.41s
✅ SignInWebSheetViewModelTests 31 31 0 0 1.28s
✅ SignOutCacheClearingTests 3 3 0 0 16ms
✅ SingletonResetRegistryTests 5 5 0 0 49ms
✅ SkeletonTests 22 22 0 0 2.12s
✅ StatsViewModelTests 10 10 0 0 863ms
✅ StatusAnnouncementTests 22 22 0 0 1.41s
✅ StopPositionSaveTests 2 2 0 0 2ms
✅ StoreTests 5 5 0 0 1.09s
✅ StreamingReaderPresentationContractTests 1 1 0 0 19ms
✅ StreamingReaderProgressStoreTests 7 7 0 0 146ms
✅ StreamingReaderViewControllerScrollRestoreTests 12 12 0 0 1.30s
✅ StreamingReaderViewModelTests 9 9 0 0 311ms
✅ StringExtensionTests 8 8 0 0 30ms
✅ StringExtensionsTests 3 3 0 0 43ms
✅ StringHTMLEntitiesTests 7 7 0 0 7ms
✅ StringNYPLAdditionsTests 4 4 0 0 8ms
✅ String_NYPLAdditionsTests 4 4 0 0 43ms
✅ SupportSectionDecisionTests 5 5 0 0 6ms
✅ SyncConflictResolutionTests 3 3 0 0 2ms
✅ SyncDeletionGuardTests 5 5 0 0 15ms
✅ SyncDeletionRatioTests 6 6 0 0 13ms
✅ SyncPermissionTests 5 5 0 0 78ms
✅ TPPAccountAuthStateEnumTests 5 5 0 0 235ms
✅ TPPAccountListDataSourceTests 3 3 0 0 137ms
✅ TPPAdobeActivationSkipTests 6 6 0 0 303ms
✅ TPPAgeCheckCompletionTests 5 5 0 0 400ms
✅ TPPAgeCheckIsValidTests 5 5 0 0 17ms
✅ TPPAgeCheckStateMachineTests 4 4 0 0 522ms
✅ TPPAgeCheckTests 6 6 0 0 48.92s
✅ TPPAgeCheckVerifyDecisionTests 5 5 0 0 425ms
✅ TPPAlertUtilsTests 45 45 0 0 3.18s
✅ TPPAnnotationsHermeticTests 15 15 0 0 160ms
✅ TPPAnnotationsOverrideTests 4 4 0 0 109ms
✅ TPPAnnotationsTests 29 29 0 0 2.51s
✅ TPPAnnouncementManagerTests 3 3 0 0 7ms
✅ TPPAuthDocumentContractTests 3 3 0 0 1.04s
✅ TPPBackgroundExecutorTests 3 3 0 0 100ms
✅ TPPBadgeImageGapTests 2 2 0 0 51ms
✅ TPPBaseReaderViewControllerInitialLocationTests 10 10 0 0 301ms
✅ TPPBasicAuthTests 11 11 0 0 78ms
✅ TPPBookAccessibilityLabelTests 8 8 0 0 23ms
✅ TPPBookAuthorCoverageTests 3 3 0 0 6ms
✅ TPPBookAuthorTests 6 6 0 0 25ms
✅ TPPBookBearerTokenTests 9 8 0 1 68ms
✅ TPPBookButtonsStateTests 7 7 0 0 10ms
✅ TPPBookContentMetadataFilesHelperTests 9 9 0 0 56ms
✅ TPPBookContentTypeConverterStreamingHTMLTests 2 2 0 0 4ms
✅ TPPBookContentTypeConverterTests 4 4 0 0 16ms
✅ TPPBookContentTypeExtendedTests 4 4 0 0 6ms
✅ TPPBookContentTypeTests 14 14 0 0 575ms
✅ TPPBookCoverRegistryTests 17 17 0 0 967ms
✅ TPPBookCreationTests 7 7 0 0 123ms
✅ TPPBookExtensionsTests 21 21 0 0 618ms
✅ TPPBookIsDRMProtectedTests 9 9 0 0 131ms
✅ TPPBookLocationCoverageTests 7 7 0 0 68ms
✅ TPPBookLocationEdgeCaseTests 27 27 0 0 150ms
✅ TPPBookLocationKeyTests 3 3 0 0 187ms
✅ TPPBookLocationTests 11 11 0 0 42ms
✅ TPPBookModelGapTests 4 4 0 0 39ms
✅ TPPBookRegistryAccountCaptureContractTests 4 4 0 0 199ms
✅ TPPBookRegistryAsyncReadinessTests 3 3 0 0 324ms
✅ TPPBookRegistryAtomicWriteTests 7 7 0 0 328ms
✅ TPPBookRegistryBookRetrievalTests 7 7 0 0 234ms
✅ TPPBookRegistryBookmarkTests 7 7 0 0 103ms
✅ TPPBookRegistryCorruptedDataTests 5 5 0 0 115ms
✅ TPPBookRegistryDataTests 4 4 0 0 17ms
✅ TPPBookRegistryDependencyTests 4 4 0 0 223ms
✅ TPPBookRegistryFacadeContractTests 6 6 0 0 116ms
✅ TPPBookRegistryFulfillmentIdTests 4 4 0 0 213ms
✅ TPPBookRegistryLargeCorpusTests 5 5 0 0 55.43s
✅ TPPBookRegistryLoadReentrancyTests 2 2 0 0 10ms
✅ TPPBookRegistryLocationTests 4 4 0 0 1.69s
✅ TPPBookRegistryMigrationTests 16 16 0 0 1.34s
✅ TPPBookRegistryMutationContractTests 10 10 0 0 658ms
✅ TPPBookRegistryPersistenceTests 10 10 0 0 595ms
✅ TPPBookRegistryProcessingTests 2 2 0 0 10ms
✅ TPPBookRegistryPublisherTests 6 6 0 0 143ms
✅ TPPBookRegistryRebuildRefusalContractTests 1 1 0 0 48ms
✅ TPPBookRegistryRecordPersistenceTests 3 3 0 0 274ms
✅ TPPBookRegistryRecordTests 10 10 0 0 173ms
✅ TPPBookRegistryStateConcurrencyTests 2 2 0 0 100ms
✅ TPPBookRegistryStateManagementTests 11 11 0 0 127ms
✅ TPPBookRegistrySyncContractTests 4 1 0 3 255ms
✅ TPPBookRegistryThreadSafetyTests 3 3 0 0 461ms
✅ TPPBookRegistryUpdateAndRemoveTests 1 1 0 0 8ms
✅ TPPBookRequiresAdobeDRMTests 6 6 0 0 73ms
✅ TPPBookSerializationTests 13 13 0 0 558ms
✅ TPPBookStateInitializationTests 4 4 0 0 6ms
✅ TPPBookStateTests 4 4 0 0 80ms
✅ TPPBookTests 98 98 0 0 7.06s
✅ TPPBookmarkDeletionLogTests 11 11 0 0 454ms
✅ TPPBookmarkFactoryInitTests 2 2 0 0 86ms
✅ TPPBookmarkFactoryServerAnnotationEdgeCaseTests 5 5 0 0 412ms
✅ TPPBookmarkFactoryTests 15 15 0 0 262ms
✅ TPPBookmarkR3ConversionTests 5 5 0 0 783ms
✅ TPPBookmarkR3LocationTests 13 13 0 0 675ms
✅ TPPBookmarkSpecTests 1 1 0 0 3ms
✅ TPPCachingTests 3 3 0 0 43ms
✅ TPPCapturedCredentialsTests 5 5 0 0 440ms
✅ TPPCirculationAnalyticsRequestShapeContractTests 2 2 0 0 159ms
✅ TPPConfigurationCustomRegistryTests 16 16 0 0 908ms
✅ TPPConfigurationTests 22 22 0 0 141ms
✅ TPPContentTypeTests 9 9 0 0 73ms
✅ TPPCredentialConcurrencyTests 3 3 0 0 125ms
✅ TPPCredentialIsolationE2ETests 5 0 0 5 216ms
✅ TPPCredentialPersistenceTests 6 6 0 0 351ms
✅ TPPCredentialSnapshotCoherenceTests 3 0 0 3 56ms
✅ TPPCredentialSnapshotTests 8 8 0 0 29ms
✅ TPPCredentialsCoverageTests 9 9 0 0 106ms
✅ TPPCredentialsTests 26 26 0 0 252ms
✅ TPPCrossLibrarySignOutTests 6 6 0 0 304ms
✅ TPPDRMFailureCredentialPreservationTests 4 4 0 0 226ms
✅ TPPErrorLoggerTests 27 27 0 0 172ms
✅ TPPIdleSignOutRegressionTests 13 13 0 0 3.32s
✅ TPPJWKConversionTest 1 1 0 0 18ms
✅ TPPKeychainManagerTests 5 5 0 0 729ms
✅ TPPLastReadPositionPosterTests 13 13 0 0 149ms
✅ TPPLastReadPositionSynchronizerIntegrationTests 5 5 0 0 175ms
✅ TPPLastReadPositionSynchronizerTests 23 23 0 0 3.05s
✅ TPPLastReadPositionSynchronizer_BehaviorDocumentationTests 5 5 0 0 492ms
✅ TPPLastReadPositionSynchronizer_BookLocationTests 9 9 0 0 140ms
✅ TPPLastReadPositionSynchronizer_ConcurrencyTests 3 3 0 0 75ms
✅ TPPLastReadPositionSynchronizer_ReadiumBookmarkTests 9 9 0 0 2.26s
✅ TPPLastReadPositionSynchronizer_SyncLogicTests 10 10 0 0 89ms
✅ TPPLastReadPositionSynchronizer_WriterDelegationTests 4 4 0 0 186ms
✅ TPPLoginNoActivationTests 3 3 0 0 2.19s
✅ TPPMainThreadCheckerTests 4 4 0 0 642ms
✅ TPPMigrationManagerTests 15 15 0 0 76ms
✅ TPPNetworkExecutorAPITests 14 14 0 0 520ms
✅ TPPNetworkExecutorConcurrencyTests 4 4 0 0 1.83s
✅ TPPNetworkExecutorStubbedTests 17 17 0 0 624ms
✅ TPPNetworkExecutorTests 3 3 0 0 102ms
✅ TPPNetworkResponderAuthCoordinatorTests 5 5 0 0 121ms
✅ TPPNetworkResponderSizeLimitTests 5 5 0 0 1.65s
✅ TPPNetworkResponderTests 12 12 0 0 355ms
✅ TPPOPDSAcquisitionPathTests 5 5 0 0 98ms
✅ TPPOPDSEntryTests 5 5 0 0 15ms
✅ TPPOPDSFeedTests 3 3 0 0 106ms
✅ TPPOPDSGroupSwiftTests 3 3 0 0 11ms
✅ TPPOPDSLinkTests 7 7 0 0 50ms
✅ TPPOpenSearchDescriptionExpandedTests 10 10 0 0 81ms
✅ TPPOpenSearchDescriptionTests 1 1 0 0 <1ms
✅ TPPPDFDocumentMetadataTests 15 15 0 0 335ms
✅ TPPPDFDocumentTests 8 8 0 0 353ms
✅ TPPPDFLocationCoverageTests 7 7 0 0 340ms
✅ TPPPDFLocationTests 10 10 0 0 18ms
✅ TPPPDFPageBookmarkTests 9 9 0 0 521ms
✅ TPPPDFPageTests 5 5 0 0 14ms
✅ TPPPDFReaderModeTests 6 6 0 0 303ms
✅ TPPPDFReaderSearchBindingTests 3 3 0 0 136ms
✅ TPPPerAccountIsolationTests 8 0 0 8 792ms
✅ TPPPreferredAuthSelectionTests 8 8 0 0 2.76s
✅ TPPProblemDocumentCacheManagerTests 12 12 0 0 113ms
✅ TPPProblemDocumentTests 21 21 0 0 64ms
✅ TPPReaderAppearanceTests 4 4 0 0 6ms
✅ TPPReaderBlockNavigationTests 12 12 0 0 142ms
✅ TPPReaderBookmarksBusinessLogicTests 12 12 0 0 514ms
✅ TPPReaderBookmarksReadinessTests 2 2 0 0 521ms
✅ TPPReaderFontTests 4 4 0 0 44ms
✅ TPPReaderFootnoteAccessibilityTests 16 16 0 0 91ms
✅ TPPReaderPageListBusinessLogicTests 27 27 0 0 843ms
✅ TPPReaderPositionReportTests 10 10 0 0 32ms
✅ TPPReaderPreferencesLoadTests 3 3 0 0 57ms
✅ TPPReaderSettingsTests 28 28 0 0 309ms
✅ TPPReaderTOCBusinessLogicTests 15 15 0 0 325ms
✅ TPPReaderTOCFlattenTests 2 2 0 0 70ms
✅ TPPReadiumBookmarkLocationMatchingTests 5 5 0 0 63ms
✅ TPPReadiumBookmarkTests 23 23 0 0 203ms
✅ TPPReauthenticatorMockTests 2 2 0 0 8ms
✅ TPPReauthenticatorTests 4 4 0 0 69ms
✅ TPPReturnPromptHelperTests 5 5 0 0 171ms
✅ TPPSAMLCookieExpirationTests 7 7 0 0 55ms
✅ TPPSAMLFlowTests 10 10 0 0 136ms
✅ TPPSAMLReauthFlowTests 2 2 0 0 141ms
✅ TPPSAMLRegressionTests 4 4 0 0 174ms
✅ TPPSAMLSignInTests 26 26 0 0 1.33s
✅ TPPSAMLStateIsolationTests 4 4 0 0 113ms
✅ TPPSAMLStateMachineTests 6 6 0 0 302ms
✅ TPPSettingsTests 6 6 0 0 287ms
✅ TPPSignInAdobeSkipTests 14 14 0 0 931ms
✅ TPPSignInAuthStateTransitionTests 3 3 0 0 403ms
✅ TPPSignInBusinessLogicExtendedTests 58 58 0 0 3.42s
✅ TPPSignInBusinessLogicOAuthTests 11 11 0 0 533ms
✅ TPPSignInBusinessLogicSignOutTests 11 11 0 0 1.18s
✅ TPPSignInBusinessLogicStateMachineTests 10 10 0 0 425ms
✅ TPPSignInBusinessLogicTests 23 23 0 0 2.78s
✅ TPPSignInBusinessLogicTokenFlowTests 3 3 0 0 269ms
✅ TPPSignInBusinessLogicValidationCallbackOrderTests 2 2 0 0 1.49s
✅ TPPSignInCapabilitiesCharacterizationTests 12 12 0 0 1.90s
✅ TPPSignInErrorHandlingTests 2 2 0 0 84ms
✅ TPPSignInProfileDocEdgeCaseTests 3 3 0 0 495ms
✅ TPPSignedInStateProviderTests 3 3 0 0 404ms
✅ TPPUserAccountAuthStateTests 6 6 0 0 83ms
✅ TPPUserAccountConcurrencyTests 1 1 0 0 3ms
✅ TPPUserAccountGapTests 4 4 0 0 29ms
✅ TPPUserAccountIsolationLintTests 3 3 0 0 972ms
✅ TPPUserAccountTestFactoryTests 7 0 0 7 64ms
✅ TPPUserFriendlyErrorTests 11 11 0 0 206ms
✅ TPPUserNotificationsTests 10 10 0 0 165ms
✅ TPPXMLSwiftTests 16 16 0 0 167ms
✅ TPPXMLTests 3 3 0 0 10ms
✅ TabBarModernizationTests 8 8 0 0 10ms
✅ TearDownRequiredLintTests 5 5 0 0 2.09s
✅ TestAppContainerFactoryTests 5 5 0 0 37ms
⚠️ TestTargetHermeticityRegressionTests 4 3 0 0 364ms
✅ TimeEntryTests 3 3 0 0 166ms
✅ TokenRefreshAndRetryQueueTests 9 9 0 0 1.79s
✅ TokenRefreshIntegrationTests 2 2 0 0 158ms
✅ TokenRefreshInterceptorAuthCoordinatorTests 8 8 0 0 236ms
✅ TokenRefreshInterceptorTests 24 24 0 0 363ms
✅ TokenRefreshOnForegroundTests 10 10 0 0 2.56s
✅ TokenRefreshTests 25 25 0 0 97ms
✅ TokenRefreshWatchdogTests 5 5 0 0 48ms
✅ TokenRequestCredentialGuardTests 13 13 0 0 911ms
✅ TokenRequestTests 11 11 0 0 210ms
✅ TokenResponseTests 21 21 0 0 250ms
✅ TriageBotKeyAdminTests 4 4 0 0 289ms
✅ TypographyPresetTests 21 21 0 0 670ms
✅ TypographyServiceTests 31 31 0 0 704ms
✅ TypographySettingsViewModelTests 27 27 0 0 642ms
✅ UIAlertCACommitGuardTests 9 9 0 0 659ms
✅ UIColor_NYPLAdditionsTests 1 1 0 0 2ms
✅ URLBackupExclusionTests 3 3 0 0 8ms
✅ URLExtensionTests 16 16 0 0 108ms
✅ URLExtensionsTests 11 11 0 0 264ms
✅ URLRequestExtensionsCoverageTests 3 3 0 0 45ms
✅ URLRequestExtensionsTests 11 11 0 0 200ms
✅ URLRequestNYPLAdditionsTests 11 11 0 0 201ms
✅ URLRequest_NYPLTests 1 1 0 0 2ms
✅ URLResponseAuthenticationTests 10 10 0 0 103ms
✅ URLResponseNYPLTests 14 14 0 0 62ms
✅ URLSessionCredentialStorageTests 3 3 0 0 5ms
✅ URLSessionStubbingResetTests 2 2 0 0 18ms
✅ URLTypeTests 2 2 0 0 13ms
✅ URLValidationTests 5 5 0 0 116ms
✅ UnifiedOPDSServiceStateMachineTests 2 2 0 0 133ms
✅ UserAccountPublisherAuthStateTests 5 5 0 0 129ms
✅ UserAccountPublisherTests 14 14 0 0 541ms
✅ UserAccountValidationTests 11 11 0 0 765ms
✅ UserDefaultsIsolationLintTests 2 2 0 0 1.02s
✅ UserProfileDocumentTests 7 7 0 0 52ms
✅ UserRetryTrackerTests 10 10 0 0 35ms
✅ XCTestCase_testUserDefaultsTests 3 3 0 0 40ms
✅ iPadOnMacRMSDKGuardTests 7 7 0 0 285ms

📊 Full interactive matrix: report

📊 Testing Coverage Breakdown

Unit Test Line Coverage (testable surfaces): 44.6%

Total coverage incl. UI/lifecycle: 43.6% (17 files excluded from testable denominator — see scripts/coverage-exclude.json)

Target Lines Covered
Palace.app 43.6%

Why two coverage numbers? Testable coverage subtracts files that can't be exercised from xcodebuild — SwiftUI views, UIKit VCs, lifecycle (see scripts/coverage-exclude.json) — so raising it means more testable logic is tested, not that we shipped less UI. Total coverage is kept for continuity. The excluded paths are covered by simdrive E2E journeys (see chaos-replay-on-pr.yml).


🔗 Interactive HTML Report | CI Run Details

Counts above were produced by this CI run's xcresult parse — reproduce via the run link.

📦 Downloadable Artifacts
Artifact Description
test-report 📄 Markdown + HTML reports
test-data 📊 JSON data for tooling
test-results 🔍 Full xcresult (open in Xcode)

…Wave 3 / 3a-2)

Second in-target collaborator split out of AccountsManager. The account-registry
STATE and all thread-safe access — the current hash, the [hash → [Account]] sets,
the O(1) accountByUUID index kept in barrier-lockstep with them, the separate slim
launch fallback, and the concurrent accountSetsLock sync-read/barrier-write
primitives — move into an injected AccountRegistryStore. The hub keeps only thin
forwarding facades. Behaviour-identical. Stacked on 3a-1.

- New AccountRegistryStore.swift: a `final class … @unchecked Sendable` (NOT an
  actor — account(_:) is a synchronous @objc TPPLibraryAccountsProvider requirement
  and the drain choreography depends on sync `.sync` reads; an actor would force
  await through the conformance and delete that timing) that owns the concurrent
  DispatchQueue verbatim. The two barrier carriers move with it.
- `accountSet` (current hash) moves into the store so ONE lock still guards
  {currentHash, accountSets, accountByUUID}. accountsForCurrentHash() /
  currentBucketIsLoaded() read the hash + its bucket in ONE performRead — preserving
  the multi-field snapshot atomicity a library switch would otherwise tear (the
  facade must NOT use accounts(forKey: currentHash), which splits it across two
  lock acquisitions). The :1900 load-trigger keeps its polarity (!bucketIsNonEmpty).
- Hub: deleted the state + performRead/performWrite/mutateAccountSets/storeSlim/
  slimAccount + the buildAccountIndex impl; injected `registryStore` via init default;
  retyped ~15 call sites; kept account/accounts/accountsHaveLoaded facades and a
  buildAccountIndex static shim (AccountsManagerAccountIndexTests calls it). The
  @unchecked Sendable audit block refreshed to point at the store.
- Tests: AccountRegistryStoreSeamTests — index-coherence-under-churn,
  no-torn-read, slim-isolation, cross-switch atomicity (Finding-1 pin), and hub-
  delegation routing; new makeFreshAccountsManager(defaults:registryStore:) helper.

Verified: god-class freeze re-baselined DOWN 2173 -> 2080 (-93); locator 304 /
shared-read 213 at baseline; package-purity clean; Palace-noDRM BUILD SUCCEEDED
(production compile). Architect BLOCKED then APPROVED after the atomicity + polarity
fixes.

**Scope:** the account-registry state + thread-safe access out of AccountsManager
into an injected store; Accounts area only.
**Not done:** the DRM PalaceTests run (incl. the new concurrency tests) executes in
CI, not locally — this change was authored in a git worktree whose Adobe-DRM test
host can't build (private dp_all.h); noDRM compile-verify passed locally. carveSlimFeed
still deferred (3a-1).
**Deferred:** the remaining three 3a collaborators (AuthDocumentLoader, RegistryLoader,
CredentialResolver, CurrentAccountStore) are separate PRs.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mauricecarrier7
mauricecarrier7 force-pushed the feat/pp-decomp-3a2-registry-store branch from 7d355fa to fd213c1 Compare July 31, 2026 17:15
@github-actions

Copy link
Copy Markdown

🏗️ CodeAtlas Ledger Analysis

✅ All Checks Passed


♿ Accessibility (via AccessLint)

💡 Static analysis against WCAG 2.1 AA guidelines for iOS accessibility.

No accessibility issues detected


🏛️ Architecture Analysis

Metric Value ℹ️ What This Means
Components 46 Distinct modules/layers detected in your codebase
Dependency Cycles 10 Circular dependencies (A→B→C→A). Goal: 0
Layer Violations 2 Dependencies that break architectural boundaries
Hotspots 13 Files with high complexity + frequent changes
Avg Coupling 4.93 How interconnected modules are (lower is better, <1.0 is good)

ℹ️ This diff changed 0 architecture-relevant files — the numbers above are the repo baseline, unchanged by this PR.

⚠️ 2 layer violation(s) — see Architecture Findings below for the offending dependency edge(s).

🔄 Dependency Cycles

See full report for cycle details.

📋 Architecture Findings

See full report for detailed findings.


🔍 Reachability Analysis

💡 Detects code that cannot be reached from entry points (dead code).

ℹ️ No architecture-relevant files in this diff — reachability not evaluated.


📊 0 files analyzed | 📦 Download Full Report

Powered by CodeAtlas Ledger
• Accessibility: AccessLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant