fix: locate template.scriban independent of process CWD - #33
Merged
StevenTCramer merged 5 commits intoAug 30, 2026
Merged
Conversation
CI schedule fails looking for template.scriban at repo root; kitchen records the heroicons path-resolution fix for the implementer.
Scheduled CI runs transform with working directory = repo root, so a relative template.scriban path FileNotFoundException aborted icon sync. Resolve the template from the binary/project dir (heroicons candidate list) and skip non-svg files with continue instead of aborting Main. Co-Authored-By: Grok 4.6 <noreply@x.ai>
Co-Authored-By: Grok 4.6 <noreply@x.ai>
Effort-1 general review raised no issues; trail and clean disposition live under the host task review/ kitchen. Co-Authored-By: Grok 4.6 <noreply@x.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scheduled CI sync (
update-icons --push --publish) crashed looking fortemplate.scribanat the repo root.tools/transformnow resolves the template from the binary/project directory (same candidate list as timewarp-heroicons) and skips non-svg files instead of abortingMain.Fixes failed run: https://github.com/TimeWarpEngineering/timewarp-simple-icons/actions/runs/33307775988
Kanban: 005
Why
CI
TransformIconsAsyncrunsdotnet run --project tools/transform/transform.csprojwith working directory = repo root. A relativeFile.ReadAllText("template.scriban")only worked whenscripts/transform.ps1Push-Locationd intotools/transform.Test plan
dotnet run --project tools/transform/transform.csproj --no-launch-profilefrom repo root and from/tmp— noFileNotFoundExceptiondotnet run tools/dev-cli/dev.cs -- build— 0 warnings, 0 errors--push --publish)Notes
ganda task workopen-prhardcodes--base master; this repo’s default branch ismain, so the host create failed. This PR was opened with--base main.