join: name the shared key container to fix HRTB normalization#798
Merged
frankmcsherry merged 1 commit intoJul 14, 2026
Merged
Conversation
Apply the same fix as the reduce commit to `join_traces` and `Arranged::join_core`. Both equated the second cursor's key to the first cursor's key projection (`for<'a> Key<'a> = BatchKey<'a, Tr1>`), a higher-ranked projection-to-projection bound that fails to normalize through a join wrapper generic over both inputs with a non-reference GAT key (columnar `Ref`), with the same `error[E0271]: expected <_ as Cursor>::Key`. Name the shared key via a container parameter `KC`: pin it from the first input's `KeyContainer` and equate both cursor keys to `KC::ReadItem`. In `join_core` this sits alongside the existing `Diff = R1/R2` pins, which solve the identical use-site-connection problem for the diff type. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the same fix as the reduce commit to
join_tracesandArranged::join_core. Both equated the second cursor's key to the first cursor's key projection (for<'a> Key<'a> = BatchKey<'a, Tr1>), a higher-ranked projection-to-projection bound that fails to normalize through a join wrapper generic over both inputs with a non-reference GAT key (columnarRef), with the sameerror[E0271]: expected <_ as Cursor>::Key.Name the shared key via a container parameter
KC: pin it from the first input'sKeyContainerand equate both cursor keys toKC::ReadItem. Injoin_corethis sits alongside the existingDiff = R1/R2pins, which solve the identical use-site-connection problem for the diff type.