Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1152
Summary
started_from_updateRationale
Trunk Recorder already records whether
Call_implwas created from a channel grant update rather than the original grant. That fact is used by the existingCall was UPDATE not GRANTlog, but plugins and call JSON consumers cannot currently observe it.This change exposes the existing state without claiming that audio is truncated or incomplete. The ordered transmission list already contains the first observed transmission timestamp, so no redundant timestamp is added.
Plugin compatibility
The new
Callaccessor is appended to the interface, andstarted_from_updateis appended as the finalCall_Data_tmember so existing member offsets are preserved.Call_Data_tis passed by value across the C++ plugin boundary, however, so its changed size still requires core and plugins to be rebuilt from a compatible source pair.Validation
call_started_from_update_testsand the external plugin provenance/audio test)/usr/local/lib/trunk-recorder