Added Wikipedia extension (fixed) by samuellouf · Pull Request #1941 · TurboWarp/extensions

samuellouf · 2025-02-19T00:21:00Z

Hello!
I'm re-pulling my "Wikipedia" extension.
I fixed the issues adressed it my previous pull request (#1075) :
See here.
It still uses MediaWiki public API.
Enjoy !
Post-scriptum :
Here is the logo :

And here is the banner :

Added my Wikipedia extension to the list

Replaced 'fetch()' by 'Scratch.fetch()'

…into Wikipedia

Detail : - Created my own logo (Puzzle piece with a W) - Added License - Returns empty strings instead of 'Error : [...]' - Added a fallback empty string for "getLanguage" - Removed "isString" cause I didn't need it - Switched the function names to camel case - Removed "wikipedia" from the function names - Added "addLanguage" - Edited JSON array filter to return JSON objects - Made a banner

NexusKitten · 2025-02-19T00:25:04Z

Just for future reference, I'm pretty sure you're allowed to reopen a commit marked as stale if you've updated it. Typically, there's nothing wrong with a stale PR, they're just closed to cut down on the amount of inactive pull requests.

- Changed User Adress - Removed text from banner

samuellouf · 2025-02-19T01:55:07Z

Oh! Ok. Thanks!

samuellouf · 2025-02-21T08:22:22Z

Finished!

Brackets-Coder

The code looks alright, but I don't know about merging this, there's some crazy stuff on Wikipedia...

Brackets-Coder · 2025-09-13T15:28:26Z

+          "---",
+          "---",


Why is there two breaks here?

I have no Idea

Brackets-Coder · 2025-09-13T15:29:30Z

+      return Scratch.fetch(
+        `https://${this.wikipediaLanguages}.wikipedia.org/w/api.php?action=query&prop=extracts&exlimit=1&titles=${encodeURIComponent(args.NAME)}&explaintext=1&exsectionformat=plain&format=json&origin=*`
+      )


I don't know about you, but I think we didn't like referencing external domains? I know some other extensions do it so I'm unsure...

it could go down

it could be whitelisted

Ohhh... I didn't think about that.
You're probably right

Brackets-Coder · 2025-09-16T21:19:29Z

@CubesterYT we closing this one too for the same reasons as #1972?

samuellouf

My bad!
English is my second language.
Thanks for noticing!

Brackets-Coder · 2026-01-15T13:56:22Z

I'll take another look when I get the chance, but I know for certain I'm crazy busy until the weekend

Brackets-Coder

Switching to any language other than English and returning the default first paragraph returns this error:
TypeError: undefined is not an object (evaluating 'extract.replace')

Switching the language also makes the "short phrase" block return nothing

Also, it might be nice if you could make the block "paragraph [number] on (article) article," but I could see how that could easily be used for plagiarizing large amounts of content

executing the default "add a language block" returns vm"error""Unexpected input recieved in replaceUnsafeChars"

Brackets-Coder · 2026-01-18T00:47:16Z

+      return Scratch.fetch(
+        `https://${this.wikipediaLanguages}.wikipedia.org/w/api.php?action=query&prop=extracts&exlimit=1&titles=${encodeURIComponent(args.NAME)}&explaintext=1&exsectionformat=plain&format=json&origin=*`
+      )
+        .then((response) => {
+          if (response.ok == true) {
+            return response.json();
+          } else {
+            return "";
+          }
+        })


Maybe make some kind of function for this repetitive part?

e.g,

fetchWiki(args).then((data) => { ... }

Egypt->Egyptian Co-authored-by: Brackets-Coder <142950368+Brackets-Coder@users.noreply.github.com>

Co-authored-by: Brackets-Coder <142950368+Brackets-Coder@users.noreply.github.com>

- Added fetchWikipedia function - Replaced phrase by sentence

outdated

Brackets-Coder · 2026-05-19T14:55:56Z

@samuellouf remind me to review this

Brackets-Coder

More coming soon

Brackets-Coder · 2026-07-09T17:26:22Z

+  function fetchWikipedia(language, name) {
+    return Scratch.fetch(
+      `https://${language}.wikipedia.org/w/api.php?action=query&prop=extracts&exlimit=1&titles=${encodeURIComponent(name)}&explaintext=1&exsectionformat=plain&format=json&origin=*`
+    )
+      .then((response) => {
+        if (response.ok == true) {
+          return response.json();
+        } else {
+          return "";
+        }
+      })
+      .catch((error) => {
+        return "";
+      });
+  }


Wrap this in Scratch.canFetch

No it uses scratch.fetch already

I'm confused? I thought we were supposed to wrap even non-native Scratch.fetch with Scratch.canFetch anyway

I knew for sure regular fetch was supposed to be wrapped

which existing extensions wrap Scratch.fetch in canFetch?

I don't know, maybe I just misunderstood

Lily's skins does

async _createURLSkin(URL, rotationCenter) { let imageData; if (await Scratch.canFetch(URL)) { imageData = await Scratch.fetch(URL); } else { return; } ...

it probably shouldn't

Scratch.fetch is literally

if (!await Scratch.canFetch(actualURL)) { throw new Error(`Permission to fetch ${actualURL} rejected.`); } return fetch(url, options);

Brackets-Coder · 2026-07-09T17:28:08Z

Getting this error on fetching anything from Wikipedia:

TypeError: undefined is not an object (evaluating 'extract.replace')

Brackets-Coder · 2026-07-09T17:29:10Z

<does page [Scratch (programming language)] exist? returns false

samuellouf · 2026-07-09T19:55:59Z

As it turns out, I was encoding the page's name as an URI component, then re-encoding it.

samuellouf · 2026-07-09T20:00:53Z

This didn't fix the problem. I'm working on it.

samuellouf · 2026-07-09T20:04:40Z

It should be work now.

samuellouf · 2026-07-09T20:12:58Z

!format

samuellouf and others added 6 commits October 2, 2023 18:40

Created Wikipedia.js

8dedb63

Update extensions.json

8a05d2c

Added my Wikipedia extension to the list

Update Wikipedia.js

fb4fcf7

Replaced 'fetch()' by 'Scratch.fetch()'

Update Wikipedia.js

56d38c1

Merge branch 'Wikipedia' of https://github.com/samuellouf/extensions …

40f625b

…into Wikipedia

github-actions Bot added the pr: new extension Pull requests that add a new extension label Feb 19, 2025

samuellouf added 2 commits February 19, 2025 01:29

Made lint and prettier fix it

c72fe96

Small changes

94660d8

- Changed User Adress - Removed text from banner

samuellouf and others added 2 commits February 20, 2025 18:34

Merge branch 'TurboWarp:master' into Wikipedia

eaee56e

Added Translation to menus

cd8d9e0

samuellouf added 2 commits February 21, 2025 13:41

Merge branch 'TurboWarp:master' into Wikipedia

f377481

Merge branch 'TurboWarp:master' into Wikipedia

55322d8

Brackets-Coder reviewed Sep 13, 2025

View reviewed changes

Update Wikipedia.js to fix incorrect pluralization

dfc3eac

This comment was marked as resolved.

Sign in to view

samuellouf commented Sep 19, 2025

View reviewed changes

samuellouf mentioned this pull request Jan 15, 2026

Made a Geolocation extension #1943

Merged

Merge branch 'TurboWarp:master' into Wikipedia

1937918

Brackets-Coder self-assigned this Jan 15, 2026

Brackets-Coder requested changes Jan 18, 2026

View reviewed changes

samuellouf and others added 2 commits January 31, 2026 06:27

Update extensions/SamuelLouf/Wikipedia.js

c18e5f9

Egypt->Egyptian Co-authored-by: Brackets-Coder <142950368+Brackets-Coder@users.noreply.github.com>

Update extensions/SamuelLouf/Wikipedia.js

946f5e9

Co-authored-by: Brackets-Coder <142950368+Brackets-Coder@users.noreply.github.com>

samuellouf and others added 2 commits January 31, 2026 06:28

Update extensions/SamuelLouf/Wikipedia.js

9426420

Co-authored-by: Brackets-Coder <142950368+Brackets-Coder@users.noreply.github.com>

Made a few changes

4f61f99

- Added fetchWikipedia function - Replaced phrase by sentence

Merge branch 'TurboWarp:master' into Wikipedia

1b43637

samuellouf requested a review from a team as a code owner July 9, 2026 16:30

Brackets-Coder requested changes Jul 9, 2026

View reviewed changes

Removed double "encodeURIComponent"

2ff0ad6

Fixed some things

08ad352

[Automated] Format code

0d2fd50

Uh oh!

Conversation

samuellouf commented Feb 19, 2025

Uh oh!

NexusKitten commented Feb 19, 2025

Uh oh!

samuellouf commented Feb 19, 2025

Uh oh!

samuellouf commented Feb 21, 2025

Uh oh!

Brackets-Coder left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Brackets-Coder commented Sep 16, 2025

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

samuellouf left a comment

Choose a reason for hiding this comment

Uh oh!

Brackets-Coder commented Jan 15, 2026

Uh oh!

Brackets-Coder left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Brackets-Coder commented May 19, 2026

Uh oh!

Brackets-Coder left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Brackets-Coder Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Brackets-Coder commented Jul 9, 2026

Uh oh!

Brackets-Coder commented Jul 9, 2026

Uh oh!

samuellouf commented Jul 9, 2026

Uh oh!

samuellouf commented Jul 9, 2026

Uh oh!

samuellouf commented Jul 9, 2026

Uh oh!

samuellouf commented Jul 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Brackets-Coder Jul 10, 2026 •

edited

Loading