Add keep-height and keep-width to Stage Size Options#1053
Open
Davvv1 wants to merge 8 commits into
Open
Conversation
stage size options
Author
|
@GarboMuffin When you have the chance, can you test that this works? I'm not sure how to test it myself. |
Author
|
I've figured out how to test it myself, and it works fine (albeit with some bugs when scaling too far) so I think it's ready besides that |
Member
|
i will try to look on the weekend |
Author
|
I could add a check for when the width/height is too extreme, and clamp it down to a reasonable size |
Listen, this is my first time doing this. Cut me some slack.
I really need to get better at this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the width/height stay the same, and changes the other to match the aspect ratio.