Skip to content

fix: when skipUpload is true skip fxmanifest extraction - #42

Merged
Tynopia merged 10 commits into
Tynopia:mainfrom
XenoS-ITA:main
Jun 20, 2026
Merged

Tynopia merged 10 commits into
Tynopia:mainfrom
XenoS-ITA:main

Conversation

@XenoS-ITA

Copy link
Copy Markdown
Contributor

This pull request enables the action to run with skipUpload set to true without requiring a full repository checkout beforehand. It achieves this by skipping text extraction from files when uploads are disabled and by refactoring the login logic

@XenoS-ITA
XenoS-ITA requested a review from Tynopia as a code owner June 15, 2026 16:25
@XenoS-ITA

Copy link
Copy Markdown
Contributor Author

Refactor for node 24

the last 2 commits changes where needed because github actions now expects js actions to run on the newer node 24 runtime, while the previous action bundle and puppeteer setup were still built around the older commonjs/ncc flow. the older puppeteer browser setup was also unreliable: it could report setup as complete while not downloading or resolving the chrome build puppeteer actually expected, causing runtime launch failures

  • Updated Puppeteer to 25.1.0 and migrate the action runtime/build output to ESM.
  • Replaced ncc with esbuild
  • Moved the action to node24 and added an ESM createRequire shim for bundled commonjs dependencies.
  • Now it will install the exact chrome build expected by puppeteer and pass the installed executable path to puppeteer.launch() so that it doesnt stale
  • Migrated test to ESM compatible jest setup and cleaned up mocks

@Tynopia
Tynopia merged commit fc36df5 into Tynopia:main Jun 20, 2026
5 of 6 checks passed
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.2.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants