Skip to content

Add railway diagrams - #152

Merged
ssmifi merged 4 commits into
mainfrom
ssm/railway-diagrams
Oct 13, 2026
Merged

ssmifi merged 4 commits into
mainfrom
ssm/railway-diagrams

Conversation

@ssmifi

@ssmifi ssmifi commented Sep 13, 2026 •

Copy link
Copy Markdown
Collaborator

Adds railway diagrams to the CLI (#141) and to the hover.
image

Currently, the railway diagrams port (from https://github.com/tabatkins/railroad-diagrams) lives inside an own railway package. We can discuss if this should be released as own go port project.

@msujew msujew left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm alright with having an internal/railroad package, but we have to improve the code organization for this. See comment below.

Comment thread internal/grammarhover/provider.go Outdated
Comment thread cmd/fastbelt/generate.go Outdated
Comment thread internal/grammar/hover_provider.go
@ssmifi
ssmifi force-pushed the ssm/railway-diagrams branch from 65d969a to e685872 Compare September 24, 2026 13:54
@ssmifi
ssmifi force-pushed the ssm/railway-diagrams branch from e685872 to 408aa3e Compare September 24, 2026 14:01
@ssmifi
ssmifi force-pushed the ssm/railway-diagrams branch from 408aa3e to 3518099 Compare September 24, 2026 14:07
@ssmifi
ssmifi marked this pull request as ready for review September 24, 2026 14:29
@ssmifi
ssmifi requested a review from msujew September 24, 2026 14:29

@msujew msujew left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks quite good now. Just one comment, see below.

Comment thread server/hover_provider.go Outdated
@ssmifi
ssmifi requested a review from msujew October 8, 2026 11:05

@msujew msujew left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, works well 👍

@ssmifi
ssmifi merged commit 92e75d9 into main Oct 13, 2026
5 checks passed
@ssmifi
ssmifi deleted the ssm/railway-diagrams branch October 13, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants