Skip to content

fix(ui5-breadcrumbs): acc findings fixed#13557

Open
PetyaMarkovaBogdanova wants to merge 3 commits into
mainfrom
fix-acc-bc
Open

fix(ui5-breadcrumbs): acc findings fixed#13557
PetyaMarkovaBogdanova wants to merge 3 commits into
mainfrom
fix-acc-bc

Conversation

@PetyaMarkovaBogdanova

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova commented May 20, 2026

Copy link
Copy Markdown
Contributor

7) Breadcrumbs (10 failing)

  • Landmark uniqueness failures (duplicate navigation labeling patterns).
  • Interaction issues in overflow/popover flows in interactive tests.
  • Includes failures in scenarios like selecting overflow item and focus/closure flow.
Component Issue Not by spec Good to have Spec refs Spec quote sentence Coverage strength
Breadcrumbs Duplicate navigation labeling Likely Yes No ACC-267, ACC-264 "Container (div or nav) should have role=navigation and aria-label=Breadcrumb Trail" and "Label 'Breadcrumb Trail' must be announced on entry" Partial (uniqueness not explicit in extracted quote)
Breadcrumbs Overflow/popover keyboard/focus failures Likely Yes No ACC-270, ACC-272, ACC-269 "Focus must be put inside dialog on active control" and "Like any other Popover (role=dialog and so on)" Direct

@ui5-webcomponents-bot

ui5-webcomponents-bot commented May 20, 2026

Copy link
Copy Markdown
Collaborator

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 20, 2026 07:09 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 20, 2026 12:27 Inactive
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova marked this pull request as ready for review May 20, 2026 14:03
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova changed the title Fix acc bc fix(ui5-breadcrumbs): acc findings fixed May 20, 2026
@yanaminkova yanaminkova self-requested a review June 10, 2026 11:52
yanaminkova

This comment was marked as outdated.

@yanaminkova yanaminkova left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's correct to use the current location text as the label for the entire breadcrumbs component.
In my opinion, if we want to fix the error "nav does not have a unique accessible", we should introduce accessibleName property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants