feat(ui5-combobox): add trigger flag to selection-change event#13567
Open
ndeshev wants to merge 5 commits into
Open
feat(ui5-combobox): add trigger flag to selection-change event#13567ndeshev wants to merge 5 commits into
ndeshev wants to merge 5 commits into
Conversation
The selection-change event now includes a `trigger` property in its detail, allowing apps to distinguish between selection sources: - "typeahead" - auto-selection from typing - "click" - user clicked an item - "keyboard" - keyboard navigation (arrow keys, home, end, page up/down)
Collaborator
|
🚀 Deployed on https://pr-13567--ui5-webcomponents-preview.netlify.app |
Replace the inline string union for the `trigger` property of the selection-change event with a proper public enum `ComboBoxSelectionChangeTrigger` (Typeahead | Click | Keyboard), matching the convention used by other UI5 enums. Add Cypress tests covering each trigger source.
ivoplashkov
had a problem deploying
to
netlify-preview
GitHub Actions
Failure
ivoplashkov
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
ivoplashkov
changed the title
ndeshev
commented
Jun 11, 2026
- Update test page triggerColors keys and labels to PascalCase
("Typeahead" / "Keyboard" / "Click") to match the public enum.
- Remove leftover "enter" reference from the test page; Enter does
not fire selection-change.
- Clarify in JSDoc that Enter does not fire selection-change but
the change event instead.
ivoplashkov
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
ivoplashkov
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selection-change event now includes a
triggerproperty in its detail, allowing apps to distinguish between selection sources:When enabled, typing does not auto-select matching items. Selection only occurs on explicit user action (Enter key, click, or keyboard navigation). This gives apps full control over when selection is applied.
noAutoSelection behavior:
Typing: no selection-change (typeahead doesn't select)
Arrow keys: selection-change fires (navigating selects items)
Enter: change event fires (confirms the selection)
Click: selection-change fires
JIRA: BGSOFUIRILA-4446
Related to #12727