feat(ui5-comobobox, ui5-multi-combobox): add custom items#13640
feat(ui5-comobobox, ui5-multi-combobox): add custom items#13640Vonahz wants to merge 13 commits into
Conversation
Sample sync reminderHTML sample changed but React sample (
Please keep both samples in sync, or ignore if the change does not apply to both. |
…combobox_custom_items
|
🚀 Deployed on https://pr-13640--ui5-webcomponents-preview.netlify.app |
…combobox_custom_items
…combobox_custom_items
…bcomponents into combobox_custom_items
| * Used for filtering, autocomplete, and mobile rendering. | ||
| * @default undefined | ||
| * @public | ||
| */ |
There was a problem hiding this comment.
do we need that? is it going to be used for the token and as a value in the input?
There was a problem hiding this comment.
Yes. It is used for the token and if value is not provided, input value fallbacks to the "text" property.
…combobox_custom_items
| /** | ||
| * @class | ||
| * The `ui5-cb-item-custom` is type of combobox item, | ||
| * that can be used to place combobox items with custom content in the combobox. |
There was a problem hiding this comment.
"that can be used to place custom content in the combobox item.
The text property is used for filtering and auto-complete."
| <> | ||
| <CheckBox | ||
| disabled={this._readonly} | ||
| checked={this.selected} |
There was a problem hiding this comment.
The "selected" property is deprecated. We should probably decide based on whether the current item value is among the selectedValues collection
| * Defines the selected state of the component. | ||
| * @default false | ||
| * @public | ||
| * @deprecated Set the `value` property on items and use the `selectedValues` property on the parent `ui5-multi-combobox` instead for programmatic selection. |
There was a problem hiding this comment.
Do not introduce deprecated property. The selected property is kept for compatibility reasons in the ComboBoxItem but in the new classes we should not use it
| tag: "ui5-mcb-item-custom", | ||
| template: MultiComboBoxItemCustomTemplate, | ||
| styles: [ComboBoxItemCustom.styles, styles], | ||
| dependencies: [...ComboBoxItemCustom.dependencies, CheckBox], |
There was a problem hiding this comment.
We don't need the dependencies declaration for the JSX renderer. It was used for the old handlebars templates
3 participants
JIRA: BGSOFUIRILA-4141
Fixes: #11731
Introduces
ui5-cbi-customandui5-mcbi-customto enable custom content in ComboBox and MultiComboBox items.