Skip to content

upipe_avfsrc: prevent useless update event #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmassiot merged 2 commits into from
Aug 7, 2026
Merged

upipe_avfsrc: prevent useless update event #1226

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06c4769
upipe_avfsrc: use sync helper
quarium Jul 29, 2026
5466b54
upipe_avfsrc: prevent useless update event
quarium Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions lib/upipe-av/upipe_avformat_source.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/*
* Copyright (C) 2012-2018 OpenHeadend S.A.R.L.
* Copyright (C) 2026 EasyTools
*
* Authors: Christophe Massiot
*
Expand Down Expand Up @@ -37,6 +38,7 @@
#include "upipe/upipe_helper_uprobe.h"
#include "upipe/upipe_helper_inner.h"
#include "upipe/upipe_helper_subpipe.h"
#include "upipe/upipe_helper_sync.h"
#include "upipe-modules/upipe_idem.h"
#include "upipe-av/upipe_avformat_source.h"

Expand Down Expand Up @@ -151,6 +153,7 @@ UPIPE_HELPER_UCLOCK(upipe_avfsrc, uclock, uclock_request, NULL,

UPIPE_HELPER_UPUMP_MGR(upipe_avfsrc, upump_mgr)
UPIPE_HELPER_UPUMP(upipe_avfsrc, upump, upump_mgr)
UPIPE_HELPER_SYNC(upipe_avfsrc, probed)

UBASE_FROM_TO(upipe_avfsrc, urefcount, urefcount_real, urefcount_real)

Expand Down Expand Up @@ -467,6 +470,7 @@ static struct upipe *upipe_avfsrc_alloc(struct upipe_mgr *mgr,
upipe_avfsrc_init_upump_mgr(upipe);
upipe_avfsrc_init_upump(upipe);
upipe_avfsrc_init_uclock(upipe);
upipe_avfsrc_init_sync(upipe);
upipe_avfsrc->timestamp_offset = 0;
upipe_avfsrc->timestamp_highest = AV_CLOCK_MIN;
upipe_avfsrc->systime_rap = UINT64_MAX;
Expand All @@ -475,7 +479,6 @@ static struct upipe *upipe_avfsrc_alloc(struct upipe_mgr *mgr,
upipe_avfsrc->url = NULL;
upipe_avfsrc->options = NULL;
upipe_avfsrc->context = NULL;
upipe_avfsrc->probed = false;

upipe_throw_ready(upipe);
return upipe;
Expand Down Expand Up @@ -738,7 +741,7 @@ static int upipe_avfsrc_probe(struct upipe *upipe)
return UBASE_ERR_EXTERNAL;
}

upipe_avfsrc->probed = true;
upipe_avfsrc_sync_acquired(upipe);
upipe_avfsrc->streams = calloc(context->nb_streams, sizeof(struct uref *));

for (int i = 0; i < context->nb_streams; i++) {
Expand Down Expand Up @@ -821,8 +824,10 @@ static void upipe_avfsrc_close(struct upipe *upipe)
upipe_avfsrc->streams = NULL;
}
ubase_clean_str(&upipe_avfsrc->url);
upipe_avfsrc->probed = false;
upipe_split_throw_update(upipe);
bool acquired = upipe_avfsrc->probed;
upipe_avfsrc_sync_lost(upipe);
if (acquired)
upipe_split_throw_update(upipe);
}

/** @internal @This reads data from the source and outputs it.
Expand Down Expand Up @@ -1099,7 +1104,7 @@ static int upipe_avfsrc_set_uri(struct upipe *upipe, const char *url)
#endif
upipe_avfsrc->timestamp_offset = 0;
upipe_avfsrc->url = strdup(url);
upipe_avfsrc->probed = false;
upipe_avfsrc_sync_lost(upipe);
upipe_notice_va(upipe, "opening URL %s", upipe_avfsrc->url);
return UBASE_ERR_NONE;
}
Expand Down Expand Up @@ -1255,6 +1260,7 @@ static void upipe_avfsrc_free(struct urefcount *urefcount_real)
av_dict_free(&upipe_avfsrc->options);
free(upipe_avfsrc->url);

upipe_avfsrc_clean_sync(upipe);
upipe_avfsrc_clean_uclock(upipe);
upipe_avfsrc_clean_upump(upipe);
upipe_avfsrc_clean_upump_mgr(upipe);
Expand Down
Loading