upipe_transfer: do not leak a reference when freeze fails - #1228
Open
JDarnley wants to merge 1 commit into
Open
Conversation
Managers allocated without a mutex always hit this: umutex_lock(NULL) returns UBASE_ERR_INVALID, so upipe_work_freeze() bails out through UBASE_RETURN without setting upipe_work->frozen, and upipe_work_thaw() then returns early on !frozen without releasing. The refcount never reaches zero, UPIPE_XFER_DETACH is never sent, and the worker thread never leaves upump_mgr_run(), hanging shutdown. Lock first and take the reference only once the lock is held. The failing path still returns UBASE_ERR_INVALID and leaves frozen untouched, so inner pipe access is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Managers allocated without a mutex always hit this: umutex_lock(NULL) returns UBASE_ERR_INVALID, so upipe_work_freeze() bails out through UBASE_RETURN without setting upipe_work->frozen, and upipe_work_thaw() then returns early on !frozen without releasing. The refcount never reaches zero, UPIPE_XFER_DETACH is never sent, and the worker thread never leaves upump_mgr_run(), hanging shutdown.
Lock first and take the reference only once the lock is held. The failing path still returns UBASE_ERR_INVALID and leaves frozen untouched, so inner pipe access is unaffected.