feat(PanelHeader,PanelHeaderContext): remove FixedLayout using#9765
Open
EldarMuhamethanov wants to merge 10 commits into
Open
feat(PanelHeader,PanelHeaderContext): remove FixedLayout using#9765EldarMuhamethanov wants to merge 10 commits into
EldarMuhamethanov wants to merge 10 commits into
Conversation
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Contributor
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9765/1ac8b5686c9f4e9eae7af43ed36212555a877b4d/pkg/@vkontakte/vkui/_pkg.tgzCommit 1ac8b56 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9765 +/- ##
==========================================
- Coverage 95.23% 95.21% -0.02%
==========================================
Files 462 464 +2
Lines 12518 12544 +26
Branches 4479 4485 +6
==========================================
+ Hits 11921 11944 +23
- Misses 597 600 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
SevereCloud
reviewed
Apr 29, 2026
vkcom-publisher
added
pr-needs-work
vkcom-publisher
added
pr-needs-work
vkcom-publisher
added
the
pr-needs-work
Contributor
|
PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно. |
vkcom-publisher
removed
the
pr-needs-work
inomdzhon
reviewed
Jun 23, 2026
| @@ -43,6 +45,8 @@ export interface PanelHeaderContextProps extends HTMLAttributesWithRootRef<HTMLD | |||
| onClose: VoidFunction; | |||
| } | |||
|
|
|||
| const ComponentDecorators = [SplitColWidthWrapper, OnboardingTooltipFixedContainer]; | |||
Contributor
There was a problem hiding this comment.
Есть кейсы когда для PanelHeaderContext нужен OnboardingTooltipFixedContainer?
Contributor
Author
There was a problem hiding this comment.
Сложно сказать. Я в целом не особо вижу смысл в компоненте OnboardingTooltipContainer. Так сделал скорее, чтобы старое поведение сохранить и ничего не сломать
| export interface BoxProps extends RootComponentProps<HTMLElement>, LayoutProps { | ||
| type BoxComponent = RootComponentProps<HTMLElement>['Component'] | React.ElementType[]; | ||
|
|
||
| function composeComponents( |
Contributor
There was a problem hiding this comment.
Кажется слишком мощная затея + пересекается #9918
vkcom-publisher
added
the
pr-needs-work
EldarMuhamethanov
force-pushed
the
e.muhamethanov/9357/remove-fixed-layout-using
branch
from
db53aef to
1ac8b56
Compare
vkcom-publisher
removed
the
pr-needs-work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FixedLayout#9357Описание
Избавился от
FixedLayoutвPanelHeaderиPanelHeaderContext. ВPanelHeaderContextиспользовалPopoverТакже в
Boxдоработал свойствоComponent, чтобы можно было прокидывать несколько декораторовRelease notes
Улучшения
FixedLayoutв реализации компонентаFixedLayoutв реализации компонента