Rc 1.4.4 to public - #1088
Merged
Merged
Conversation
…creation limit Every Veil PoS block's coinstake mints its block reward as zerocoin outputs, and CheckTxInputs returns that entire reward as the coinstake's txfee, which ConnectBlock folds into nFees. The creation-limit check then did nCreationLimit += nFees for any block whose fProofOfFullNode flag was set, so the reject nCreated <= nCreationLimit became R <= base + R, satisfied for any reward R up to MoneyRange. fProofOfFullNode is a serialized, non-hash-committed block field that no honest block ever sets (the staker computes hashPoFN but leaves the flag false), so any staker could set the flag, compute the public hashPoFN, and mint arbitrary VEIL from a single stake. Widen the creation limit only past the scheduled supply-creation stop height, and never by the coinstake's own reward. Honest blocks never set the flag and, with supply intact, no historical block ever over-created, so this rejects nothing that validated before.
Used contrib/devtools/copyright_header.py to update each file containing a copyright header for "The Veil Core developers" if git (not file) change time stamp is a later year than the claimed copyright year.
- Corrected copyright_headers.py script somewhat, corrected some mistakes it made, added some commentary on the script, and added a script to sort git blame chronologically to accurately ensure the correct copyright year. - Corrected the main copyright year for the master branch having corrected it previously. only on a release branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the release candidate for 1.4.4.0.
More details with be published later.
Project and Team nodes have already been updated.
You may wait for the full release to be published, but it will be a mandatory upgrade.