Add mirror source structure for verified files#1800
Merged
Conversation
Nests `.verified.` files in sub-directories that mirror the directory structure of the test source files relative to the project directory, so a test in Foo/FooTests.cs writes to Snapshots/Foo instead of a flat Snapshots folder. This makes orphaned snapshots easier to identify when test source files are moved, renamed, or removed. Behavior is unchanged when the option is not set. The derivation is shared via the public PathInfo.DeriveProjectRelative so all six adapters use one implementation. It cannot live on core Extensions/IoHelpers: each adapter has a local Extensions.cs that shadows the core type, and Verify.Fixie is unsigned so it has no InternalsVisibleTo access to core internals. Resolves #1758
Adding an optional parameter changed the method signature, so assemblies compiled against the single argument overload would fail at runtime with a MissingMethodException. Restore the single argument overload and mark it obsolete, and apply OverloadResolutionPriority to the mirrorSourceStructure overload so source callers bind to it rather than to the obsolete one. The obsolete overload remains only to keep existing binaries working. Polyfill supplies OverloadResolutionPriorityAttribute for the target frameworks whose BCL lacks it.
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1758