Repository navigation
VCST-5337: Allow the prerelease GA4 Data API client in the stable package - #64
Merged
Merged
Conversation
…5104)
Google publishes Google.Analytics.Data.V1Beta only as prerelease, so the
stable 4.1005.0 release failed at Publish Nuget: NU5104 ("a stable release
of a package should not have a prerelease dependency") is an error under
TreatWarningsAsErrors. The Data project now suppresses it, as the Data
project of vc-module-azure-search does. PR builds and alphas are prerelease
packages themselves, so only a stable pack shows the warning.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
OlegoO
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the module's release. The stable
VirtoCommerce.GoogleEcommerceAnalyticsModule.Datapackage could not be packed: it depends onGoogle.Analytics.Data.V1Beta, which Google publishes only as prerelease (every version is a beta). NuGet reports that as NU5104, and this repository treats warnings as errors, so the 4.1005.0 release stopped at "Publish Nuget" and published nothing (failed run). The Data project now suppresses NU5104, as the Data project of vc-module-azure-search does. The package keeps the sameGoogle.Analytics.Data.V1Beta 2.0.0-beta10dependency that #61 added.No code change: no schema change, no migrations, no new settings, no new dependencies.
Unblocks VirtoCommerce/vc-module-sales-rep#15, which pins this module's release.
New GraphQL queries and mutations
None.
Changes to existing GraphQL queries and mutations
None.
New public services / interfaces / methods
None.
New protected methods (extensibility)
None.
Breaking changes
None.
New dependencies
None. The prerelease
Google.Analytics.Data.V1Betadependency came with #61; this PR only lets the stable package carry it.References
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-5337
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.GoogleEcommerceAnalytics_4.1006.0-pr-64-2a19.zip
🤖 Generated with Claude Code