Skip to content

fix: remove unnecessary Pool(1) wrapper in _VwPy.run() #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JohnLangford wants to merge 1 commit into from
Closed

fix: remove unnecessary Pool(1) wrapper in _VwPy.run() #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions from_mwt_ds/DataScience/vw_executor/vw.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,11 @@ def __init__(self):
super().__init__(None)

def run(self, args: str, filename=None) -> Iterable[str]:
from multiprocessing import Pool
with Pool(1) as p:
# Use spawn context to avoid fork issues with pybind11
# Each VW call runs in its own subprocess for isolation
import multiprocessing
ctx = multiprocessing.get_context('spawn')
with ctx.Pool(1) as p:
return p.apply(_run_pyvw, [args], {"filename": filename})

def symlink(source:Path, link_name:Path):
Expand Down
Loading