Skip to content

fix: validate Debian versions with dpkg and honor the changelog input #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshschmelzle merged 1 commit into from
Sep 23, 2026
Merged

fix: validate Debian versions with dpkg and honor the changelog input #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/check-py-deb-pkg-versions-match.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,16 @@ jobs:

- name: Extract Version from Debian changelog
id: extract-version
env:
CHANGELOG: ${{ inputs.debian_changelog_file_path }}
run: |
DEB_VERSION=$(head -n 1 debian/changelog | sed -E 's/.*\(([^)]+)\).*/\1/')
DEB_VERSION=$(head -n 1 "$CHANGELOG" | sed -E 's/.*\(([^)]+)\).*/\1/')
if [ -z "$DEB_VERSION" ]; then
echo "Error: failed to parse or find version on the first line of debian/changelog"
echo "Error: failed to parse or find version on the first line of $CHANGELOG"
exit 1
fi
# Strip the debian revision (e.g., -1) for Python package version
PY_COMPAT_DEB_VERSION=$(echo "$DEB_VERSION" | sed -E 's/-.*//')
# Strip the epoch (e.g., 1:) and debian revision (e.g., -1) for Python package version
PY_COMPAT_DEB_VERSION=$(echo "$DEB_VERSION" | sed -E 's/^[0-9]+://; s/-.*//')
if [ -z "$PY_COMPAT_DEB_VERSION" ]; then
echo "Error: failed to set PY_COMPAT_DEB_VERSION from DEB_VERSION"
exit 1
Expand All @@ -51,8 +53,7 @@ jobs:

- name: Check if Debian version is valid
run: |
debian_version_regex='^(\d+!)?[0-9][A-Za-z0-9.\+~:-]*(?:-[A-Za-z0-9.\+~]+)?$'
if ! echo "$DEB_VERSION" | grep -Eq "$debian_version_regex"; then
if ! dpkg --validate-version "$DEB_VERSION"; then
echo "Error: Invalid Debian version format detected: $DEB_VERSION"
exit 1
else
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/get-formatted-version-string.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,20 @@ jobs:

- name: Extract Version from Debian Changelog
id: extract-version
env:
CHANGELOG: ${{ inputs.debian_changelog_file_path }}
run: |
DEB_VERSION=$(head -n 1 debian/changelog | sed -E 's/.*\(([^)]+)\).*/\1/')
DEB_VERSION=$(head -n 1 "$CHANGELOG" | sed -E 's/.*\(([^)]+)\).*/\1/')
if [ -z "$DEB_VERSION" ]; then
echo "Error: failed to parse or find version on the first line of debian/changelog"
echo "Error: failed to parse or find version on the first line of $CHANGELOG"
exit 1
fi
echo "DEB_VERSION=$DEB_VERSION" >> "$GITHUB_ENV"
echo "Debian package version: $DEB_VERSION"

- name: Check if Debian version is valid
run: |
debian_version_regex='^(\d+!)?[0-9][A-Za-z0-9.\+~:-]*(?:-[A-Za-z0-9.\+~]+)?$'
if ! echo "$DEB_VERSION" | grep -Eq "$debian_version_regex"; then
if ! dpkg --validate-version "$DEB_VERSION"; then
echo "Error: Invalid Debian version format detected: $DEB_VERSION"
exit 1
else
Expand Down