Add atomic ordering param to memop - #257
Merged
Merged
Conversation
stevenfontanella
marked this pull request as ready for review
July 30, 2026 18:07
Member
Author
|
cc @conrad-watt and @rossberg for review since I can't assign a reviewer myself. Can one of you help take a look? For context, this refactoring is to enable the code changes for the relaxed atomics proposal. I'm looking to get the spec interpreter working for it before we try for a phase 3 vote. |
rossberg
approved these changes
Jul 30, 2026
rossberg
left a comment
rossberg
left a comment
Member
There was a problem hiding this comment.
LGTM
(Note: I'm on vacation from tomorrow onwards, so won't be able to do more code reviews in a while.)
Member
Author
|
Thanks! I don't have permission to merge, can you merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For use in the relaxed atomics proposal, e.g. WebAssembly/relaxed-atomics#5 (based on top of this PR). This allows us to introduce more orderings (e.g. acqrel, and potentially others) to atomic instructions.
Keeping the ordering in the
memoprecord allows us to avoid introducing a secondatomicmemoprecord and duplicating several functions that usememope.g. in decode.ml, encode.ml, arrange.ml, and valid.ml.