Skip to content

Use HTML table for overloaded methods to resolve Bikeshed fatal errors - #2697

Open
hoch wants to merge 1 commit into
mainfrom
fix-bikeshed-overload-tables
Open

hoch wants to merge 1 commit into
mainfrom
fix-bikeshed-overload-tables

Conversation

@hoch

@hoch hoch commented Sep 11, 2026

Copy link
Copy Markdown
Member

Bikeshed currently fails with fatal errors on method overloads when using the <pre class=argumentdef> syntax (speced/bikeshed#1192).

This replaces the argumentdef blocks for earlier overloads of:

  • OfflineAudioContext constructor(contextOptions)
  • AudioNode.connect(destinationNode, output, input)
  • AudioNode.disconnect(destinationNode)
  • AudioNode.disconnect(destinationNode, output)
  • AudioNode.disconnect(destinationNode, output, input)

with explicit HTML <table class="data"> definitions. This produces identical output while bypassing Bikeshed's argumentdef overload bug, clearing all fatal errors and allowing clean TR autopublishing.

Also clears expected-errs.txt as the build is now 100% error-free.

Bikeshed currently fails with fatal errors on method overloads when using the <pre class=argumentdef> syntax (speced/bikeshed#1192).

This replaces the argumentdef blocks for earlier overloads of:
- OfflineAudioContext constructor(contextOptions)
- AudioNode.connect(destinationNode, output, input)
- AudioNode.disconnect(destinationNode)
- AudioNode.disconnect(destinationNode, output)
- AudioNode.disconnect(destinationNode, output, input)

with explicit HTML <table class="data"> definitions. This produces identical output while bypassing Bikeshed's argumentdef overload bug, clearing all fatal errors and allowing clean TR autopublishing.

Also clears expected-errs.txt as the build is now 100% error-free.
@hoch

hoch commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

Spec Rendering Verification (Live W3C Preview)

The PR branch has been verified against the official W3C Spec Generator service:

Visual & Normative Verification

All 5 overloaded method tables render cleanly with complete argument metadata (previously rendering blank cells on main):

(NOTE: These links take long to load but the existing pr-preview is sort of broken. So...)

Some Notes for Reviewers

  1. Zero Regression: Table structure, classes (data), captions, styles, and dfn slide-out panels match Bikeshed's native output.
  2. Fixes Blank Cells on main: Due to upstream bug speced/bikeshed#1192, main previously omitted types and optionality flags (emitting empty <td> cells) on all earlier overloads. This PR restores those missing fields.
  3. Cross-Links Intact: All WebIDL types, parameters, and exception definitions (InvalidAccessError, IndexSizeError) link correctly.

@hoch hoch self-assigned this Sep 11, 2026
@hoch
hoch requested a review from padenot September 11, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant