Conversation
Bikeshed currently fails with fatal errors on method overloads when using the <pre class=argumentdef> syntax (speced/bikeshed#1192). This replaces the argumentdef blocks for earlier overloads of: - OfflineAudioContext constructor(contextOptions) - AudioNode.connect(destinationNode, output, input) - AudioNode.disconnect(destinationNode) - AudioNode.disconnect(destinationNode, output) - AudioNode.disconnect(destinationNode, output, input) with explicit HTML <table class="data"> definitions. This produces identical output while bypassing Bikeshed's argumentdef overload bug, clearing all fatal errors and allowing clean TR autopublishing. Also clears expected-errs.txt as the build is now 100% error-free.
Member
Author
Spec Rendering Verification (Live W3C Preview)The PR branch has been verified against the official W3C Spec Generator service:
Visual & Normative VerificationAll 5 overloaded method tables render cleanly with complete argument metadata (previously rendering blank cells on (NOTE: These links take long to load but the existing pr-preview is sort of broken. So...)
Some Notes for Reviewers
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bikeshed currently fails with fatal errors on method overloads when using the
<pre class=argumentdef>syntax (speced/bikeshed#1192).This replaces the argumentdef blocks for earlier overloads of:
OfflineAudioContext constructor(contextOptions)AudioNode.connect(destinationNode, output, input)AudioNode.disconnect(destinationNode)AudioNode.disconnect(destinationNode, output)AudioNode.disconnect(destinationNode, output, input)with explicit HTML
<table class="data">definitions. This produces identical output while bypassing Bikeshed'sargumentdefoverload bug, clearing all fatal errors and allowing clean TR autopublishing.Also clears expected-errs.txt as the build is now 100% error-free.