chore(sdk-core): regenerate SysioContractTypes for uwreqs.target_amount - #65
Merged
Conversation
wire-sysio#550 added `target_amount` to `uw_request_t` — the destination amount the caller asked for, retained as the fixed reference the depot's slippage check measures against, distinct from `dst_amount` (the AMM quote, re-priced at settlement). The regen against current `sysio.uwrit.abi` picks up exactly that one additive field on `SysioUwritUwRequestTType`; nothing else in the generated surface moves. Unblocks wire-tools-ts#58, whose swap-scenario fixture cannot carry the field until the type declares it. Change-Id: I57a657ab7c80a7b45ed95e0eed054a7ccf69814e
jglanz
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerated from the current
sysio.uwrit.abionwire-sysio@master. The diff is one line:export interface SysioUwritUwRequestTType { ... dst_amount: number | string + target_amount: number | string variance_tolerance_bps: numberWhy
wire-sysio#550 added
target_amounttouw_request_t: the destination amount the caller asked for, retained as the fixed reference the depot's slippage check measures against. It is deliberately distinct fromdst_amount, which is the depot's AMM quote and is re-priced at settlement —sysio.uwrit.hppstatesdst_amountis "never the caller'starget_amount".That contract change merged on 08-07; the TypeScript surface was never regenerated, so
SysioUwritUwRequestTTypestill ended atvariance_tolerance_bps.Scope
A full regen against every current ABI produces exactly this one added field and no other change — verified by diffing the generator output against
masterbefore committing. There is no unrelated ABI drift riding along.Unblocks
wire-tools-ts#58, which carries
uwreqs.target_amountin the swap-scenario fixture and is red by construction until this type declares the field. That PR's "do not merge yet" banner refers to this regen.Verification
pnpm buildclean; the field reaches bothlib/cjsandlib/esmSysioContractTypes.d.tspnpm test— 76 suites, 885 tests, all passing