-
Notifications
You must be signed in to change notification settings - Fork 11
feat(opp-solana): drive resumable inbound dispatch; delete the depot-side terminal budget #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
valthon
wants to merge
3
commits into
master
Choose a base branch
from
feat/resumable-opp-dispatch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
119 changes: 0 additions & 119 deletions
119
contracts/sysio.msgch/include/sysio.msgch/solana_terminal_budget.hpp
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
queueoutlost its only chain_code registration check — an authorized caller's typo now creates a permanent, unreachable READY row.All 8 production call sites derive their code from
sysio.chains(epoch:686,729; opreg:634,673,745; uwrit:349,561; reserv:153), so this is not an attack vector — but it is an ops footgun: a governance msig holding one of the authorized authorities pushingqueueoutdirectly with an unregistered code used to abort with"chain_code is not registered"; now it succeeds silently.epoch::advanceonly fansbuildenvto registered active outposts, the PROCESSED-drain (lines 1853-1860) skips mismatched chain codes, and no prune action exists — the row is permanentsysio-pool RAM, re-walked by the Phase-1bystatusscan on everybuildenvfor every outpost, every epoch.Related cleanup if the removal stands:
sysio.reserv.cpp:93-95("sysio.msgch::queueoutfails loudly for direct callers"),sysio.msgch_tests.cpp:164-170, andsysio.reserv_tests.cpp:411-414all still describe the deleted guard — a future reader will conclude msgch is the backstop and relax the reserv-side guards. Alsobuildenv's chains fetch (new lines 1648-1651) now asserts with the bare default"key not found"— worth passing the message overload.