-
Notifications
You must be signed in to change notification settings - Fork 2
Fix: claim the credited swap-to-WIRE payout instead of waiting on a balance #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
heifner
wants to merge
8
commits into
master
Choose a base branch
from
sec-150-claim-flows
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
402748e
fix(swap-to-wire): claim the credited payout instead of waiting on a …
heifner d63c4a9
Merge remote-tracking branch 'origin/master' into sec-150-claim-flows
heifner 5742a26
fix(swap-to-wire): hoist the claimable poll into a named predicate
heifner 2ca9733
fix(swap-to-wire): return the claimable poll predicate from a factory
heifner 01e182b
Merge remote-tracking branch 'origin/master' into sec-150-claim-flows
heifner bb39e07
fix(cluster-tool): name the claimable row shape instead of inlining it
heifner c50b630
fix(cluster-tool): encode the claimable-table bounds the node can act…
heifner 86f1f0b
fix(cluster-tool): read the claimable row with a lower bound only
heifner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't have try to fix my nit picking lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol, ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 2ca9733 —
claimableReachedPredicate(ctx, account, target)returns the bound predicate andpollUntiltakes it directly, no inline lambda.One substitution:
AsyncFunctionisn't exported anywhere in the tree (not@wireio/shared, not@wireio/cluster-tool, not the deps), so the return type is spelled() => Promise<boolean>—pollUntil's ownpredicateparameter type.getWireClaimablereturnsPromise<bigint>andtargetis abigint, so the.thennarrows as expected.underwritersActiveis left as-is: it predates this PR onmaster, so converting it would widen the diff past the review.